From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B8EC4363A for ; Wed, 21 Oct 2020 18:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2449822456 for ; Wed, 21 Oct 2020 18:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mYy+DTpA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438886AbgJUS2B (ORCPT ); Wed, 21 Oct 2020 14:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438881AbgJUS2B (ORCPT ); Wed, 21 Oct 2020 14:28:01 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ECDDC0613CE; Wed, 21 Oct 2020 11:28:01 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id g16so1599303pjv.3; Wed, 21 Oct 2020 11:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IF/s4Bj/loImFjDigWUw9owchow7UQ79UQNQgh6UzFU=; b=mYy+DTpA/zpKYrmSP0rCC3VF3r7kLugwuWaaW9U6Nj6OOWiIJJaFKRyMfKd+6TVOHz rc0+MrbnMSIYD/dTk0vY+KEoWLo33qrD38IvVZ1IPhF9v+RnhZ/OqTmsW1nEr7j7ameu Yi8aAzjUL9dQMqDKYdycSdJp0TbKsfZR25M9XWk22T6ccN2B+xrV2Ib8qZAI4Omn1qew 8+pI81y1YJ86oyG4S4l84E5+4dGHpMMCNDbIGX71vssDlBnwfPgm+gmObNLaVVOJCod4 RBesT/2QQfw+Ty8bAZsOUFXDOyK1r9J+ULmRq0x0hkFdLOgcAWsDsMCyH2/7Kg5V1u2M m9SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IF/s4Bj/loImFjDigWUw9owchow7UQ79UQNQgh6UzFU=; b=Pz/ZSIfsSlJljiTkUXheQ5d2qBSafpDSZk64a27vKWbIQUdTlb5jiq+E7kpusFJ8fO TPYj79Zhomy9HXx4q/5lyw7fjE1CqQFOjlrZmhVZQS2+LeqG2whpTYfSKHIK5cMyu+9d bReYszvI7+70OR5B5XbMxNWNxXYscDsxJTErENoQMn2JxB7xOxaGmrWzj46RLUEO8PRw jOXaX/+9wp8GvLJDqz+Lgh3sNdDYZcOo+ni+GX6zQxm1X5wfFm163DD+1Hp8hCWvSInO Yw+4OwaOO3ODk9S6EUbwDDxwq7py9XQrTiaywEJZXZlhVFrkPx/nlH4VbET5LNmlCLYb s4Xw== X-Gm-Message-State: AOAM533GC8B9GoUVUY65o8O1njYlJRI1AKZVbMnPXSoTG1pC8bT2q5a/ edepvNB1m7H5pcAR6xemXlU= X-Google-Smtp-Source: ABdhPJxcXuN5vS1Tk10DKp8I3dnGMQmPkDCBMWXEVEz7wmXQug/nIK37OBzW4xxP6A0ADofqwaFMaA== X-Received: by 2002:a17:90b:38f:: with SMTP id ga15mr4497112pjb.33.1603304880771; Wed, 21 Oct 2020 11:28:00 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id b21sm3113638pfb.97.2020.10.21.11.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 11:27:59 -0700 (PDT) Date: Wed, 21 Oct 2020 11:27:57 -0700 From: Dmitry Torokhov To: Oleksij Rempel Cc: "Ardelean, Alexandru" , "kernel@pengutronix.de" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , David Jander Subject: Re: [PATCH v1] Input: ads7846: do not overwrite spi->mode flags set by spi framework Message-ID: <20201021182757.GA444962@dtor-ws> References: <20201021090434.16387-1-o.rempel@pengutronix.de> <20201021105614.tc3jnv5g62hvl5vg@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201021105614.tc3jnv5g62hvl5vg@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Oct 21, 2020 at 12:56:14PM +0200, Oleksij Rempel wrote: > > As you can see, I would need to configure my dts with spi-cs-high flag, > even if the hardware is actually ACTIVE_LOW. If I will go this way, I > would risk a regression as soon as this issue is fixed. > > Since the spi framework is already parsing devicetree and set all needed > flags, I assume it is wrong to blindly drop all this flags in the > driver. Yes, but I wonder if the devices can only work in mode 0 we should be doing: spi->mode &= ~SPI_MODE_MASK; // to be defined as 0x03 in spi.h spi->mode |= SPI_MODE_0; as we can't simply "or" mode value as is (well, mode 0 is kind of working, but just on accident). Thanks. -- Dmitry