From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7362CC4363A for ; Fri, 30 Oct 2020 12:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 155D82076E for ; Fri, 30 Oct 2020 12:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604060310; bh=rTUCskofcejaNV/fI9K6l3yz9Z3J3fA43M7XsVa9EUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QzjwddsBElrXDXuvGI3sIEq/KeooyU2sulkWmYoa+83VvEbvqCfwfU5jH/2Q/AOa1 zvj2rDty9ixO4wFQUA8hBQVGt9cIUUNjyV/RYpLMEctMih0zOb6FwkKeb9mQIzxDW1 tKuA+XigtvPAOapREyAzPXjLPAnGQNH2JLV7m9As= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbgJ3MS3 (ORCPT ); Fri, 30 Oct 2020 08:18:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:47828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgJ3MS3 (ORCPT ); Fri, 30 Oct 2020 08:18:29 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDD7B20724; Fri, 30 Oct 2020 12:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604060307; bh=rTUCskofcejaNV/fI9K6l3yz9Z3J3fA43M7XsVa9EUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gGas1L8ZMREn+b7fSRIEk6jXm0xlmFxr5iZINA1C5AmawbKK6eq2jd+b8hKry4TXb /1PWD4Ws5RFNOghKPyFbFHmEV0YvuQpBvUihVvtRm91dxpvcWHwOHrSU73LR4Yz4xB 5/WCOf90GN9y/BKtkzOPMPSsPab/YurqUc1E+YW8= Date: Fri, 30 Oct 2020 13:19:15 +0100 From: "gregkh@linuxfoundation.org" To: Jungrae Kim Cc: HyungJae Im , "manivannan.sadhasivam@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "rydberg@bitmath.org" Subject: Re: Re: (3) [PATCH v2] input: add 2 kind of switch Message-ID: <20201030121915.GA2522106@kroah.com> References: <20201030114142.GA2409436@kroah.com> <20201030104628.GB2395528@kroah.com> <20201029135715.GB3470996@kroah.com> <20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p8> <20201030043916epcms1p3b289ca5cd902883a97e7d13ceb5c1efb@epcms1p3> <20201030112812epcms1p7d031bb4949b319135e48dfac9409743b@epcms1p7> <20201030115918epcms1p4aaae97a4549a1b3e505709fed3d91ecb@epcms1p4> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201030115918epcms1p4aaae97a4549a1b3e505709fed3d91ecb@epcms1p4> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Oct 30, 2020 at 08:59:18PM +0900, Jungrae Kim wrote: > > On Fri, Oct 30, 2020 at 08:28:12PM +0900, Jungrae Kim wrote: > > > > On Fri, Oct 30, 2020 at 01:39:16PM +0900, HyungJae Im wrote: > > > > > Hello, This is Hyungjae Im from Samsung Electronics. > > > > > Let me answer your questions inline. > > > > > > > > > > >On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote: > > > > > >> From: "hj2.im" > > > > > >> Date: Thu, 29 Oct 2020 22:11:24 +0900 > > > > > >> Subject: [PATCH v2] input: add 2 kind of switch > > > > > > > > > > > >Why is this in the body of that patch? > > > > > > > > > > I read "how to send your first kernel patch", but still making so many mistakes. > > > > > I will be cautious with this. > > > > >  > > > > > >> > > > > > >> We need support to various accessories on the device, > > > > > >> some switch does not exist in switch list. > > > > > >> So added switch for the following purpose. > > > > > >> > > > > > >> SW_COVER_ATTACHED is for the checking the cover > > > > > >> attached or not on the device. SW_EXT_PEN_ATTACHED is for the > > > > > >> checking the external pen attached or not on the device > > > > > > > > > > > >You didn't answer the previous question as to why the existing values do > > > > > >not work for you instead of having to create new ones? > > > > > > > > > >  I think I should clarify this part the most for this review. > > > > >  As you know, new added events both has similar existing events, > > > > >  but it has to operate separately. > > > > > > > > > >  First, SW_COVER_ATTACHED is similar with SW_MACHINE_COVER. > > > > >  We need two events for our cover interaction. > > > > >  One is to detect if flip cover is open/closed(covers screen or not), > > > > >  and one is for detecting if cover is attached(detect if device is put into cover). > > > > >  With the second event, we send event for attachment and start authentication > > > > >  distinguishing if it was Samsung made cover. > > > > > > > > > >  Second, SW_EXT_PEN_ATTACHED detects if pen is attached externally on tablet models. > > > > >  It is different with SW_PEN_INSERTED since this is detecting pens like our NOTE series. > > > > >  SW_EXT_PEN_ATTACHED has an unique role to set wacom tuning table differently > > > > >  while pen is attached/detached. > > > >  > > > > All of that needs to go in the changelog text for the individual patches > > > > when you submit them. > > > >  > > > > But as Dmitry pointed out, it doesn't look like either of these drivers > > > > are needed at all, just use the gpio-keys driver instead. > > > >  > > > > thanks, > > > >  > > > > greg k-h > > >  > > > Can you accept V1 patch? or need to add a change of device tree? > > > > What is "v1" patch?  Do you have a pointer to it on lore.kernel.org? > > > > > Please let me know what do I do now. > > > > What is wrong with just using a device tree entry for the gpio-keys > > driver instead? > > > > thanks, > > > > greg k-h > > V1 Patch : https://lore.kernel.org/lkml/20201021031216epcms1p556d8d7d5d763ec47f67cd8cbe3972935@epcms1p5/ As I said there, that patch is not acceptable for style reasons alone, nothing we can do with that unless it is fixed, right? > I think do not need modify gpio_keys. And I`m not sure device tree need to added to patch. No, you don't need to modify it, just use it. So what exactly is the issue anymore? Just use the gpio-keys driver and all should be fine, right? thanks, greg k-h