From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: <dmitry.torokhov@gmail.com>, <eugen.hristev@microchip.com>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<paul@pgazz.com>, <jeho@cs.utexas.edu>
Subject: Re: [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC
Date: Tue, 3 Nov 2020 10:58:17 +0000 [thread overview]
Message-ID: <20201103105817.00005a7f@Huawei.com> (raw)
In-Reply-To: <20201102221504.541279-1-fazilyildiran@gmail.com>
On Tue, 3 Nov 2020 01:15:05 +0300
Necip Fazil Yildiran <fazilyildiran@gmail.com> wrote:
> When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]
>
> The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
> on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
> can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index f012fe746df0..cc18f54ea887 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -96,6 +96,7 @@ config TOUCHSCREEN_AD7879_SPI
> config TOUCHSCREEN_ADC
> tristate "Generic ADC based resistive touchscreen"
> depends on IIO
> + select IIO_BUFFER
> select IIO_BUFFER_CB
> help
> Say Y here if you want to use the generic ADC
next prev parent reply other threads:[~2020-11-03 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 22:15 [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC Necip Fazil Yildiran
2020-11-03 10:58 ` Jonathan Cameron [this message]
2020-11-12 1:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103105817.00005a7f@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eugen.hristev@microchip.com \
--cc=fazilyildiran@gmail.com \
--cc=jeho@cs.utexas.edu \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pgazz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).