From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Jiri Kosina <jkosina@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Input <linux-input@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Kai Heng Feng <kai.heng.feng@canonical.com>,
andrea@borgia.bo.it, Aaron Ma <aaron.ma@canonical.com>,
Daniel Playfair Cal <daniel.playfair.cal@gmail.com>,
Jiri Kosina <jikos@kernel.org>, Pavel Balan <admin@kryma.net>,
You-Sheng Yang <vicamo.yang@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing
Date: Tue, 3 Nov 2020 10:32:21 -0800 [thread overview]
Message-ID: <20201103183221.GA1003057@dtor-ws> (raw)
In-Reply-To: <CAO-hwJK2DfU_v==uwWyyPkH9N6zb9Vh_pJOxz8dZ_mqJ1+CdsA@mail.gmail.com>
On Tue, Nov 03, 2020 at 01:42:47PM +0100, Benjamin Tissoires wrote:
>
> I also want to say that I like the general idea of Doug's patch.
> Having a separate driver that handles the specific use case of goodix
> is really nice, as it allows to just load this driver without touching
> the core of i2c-hid. I believe this is in line with what Google tries
> to do with their kernel that OEMs can not touch, but only add overlays
> to it. The implementation is not polished (I don't think this new
> driver belongs to the input subsystem), but I like the general idea of
> having the "subclassing". Maybe we can make it prettier with Hans'
> suggestion, given that this mainly means we are transforming
> i2c-hid-core.c into a library.
>
> As for where this new goodix driver goes, it can stay in
> drivers/hid/i2c-hid IMO.
Yep, I agree, it has nothing to do with input (except the device being
physically a touchscreen ;) ), so driver/hid/i2c-hid makes most sense to
me too.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-11-03 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 0:12 [PATCH v3 1/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-11-03 0:12 ` [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing Douglas Anderson
2020-11-03 1:46 ` Rob Herring
2020-11-03 9:09 ` Hans de Goede
2020-11-03 12:42 ` Benjamin Tissoires
2020-11-03 18:32 ` Dmitry Torokhov [this message]
2020-11-03 0:12 ` [PATCH v3 3/3] Input: Introduce goodix-i2c-hid as a subclass of i2c-hid Douglas Anderson
2020-11-10 11:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103183221.GA1003057@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aaron.ma@canonical.com \
--cc=admin@kryma.net \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=daniel.playfair.cal@gmail.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=vicamo.yang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).