From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: Jonathan.Cameron@huawei.com, eugen.hristev@microchip.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
paul@pgazz.com, jeho@cs.utexas.edu
Subject: Re: [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC
Date: Wed, 11 Nov 2020 17:49:03 -0800 [thread overview]
Message-ID: <20201112014903.GC1003057@dtor-ws> (raw)
In-Reply-To: <20201102221504.541279-1-fazilyildiran@gmail.com>
On Tue, Nov 03, 2020 at 01:15:05AM +0300, Necip Fazil Yildiran wrote:
> When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]
>
> The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
> on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
> can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2020-11-12 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 22:15 [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC Necip Fazil Yildiran
2020-11-03 10:58 ` Jonathan Cameron
2020-11-12 1:49 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112014903.GC1003057@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=eugen.hristev@microchip.com \
--cc=fazilyildiran@gmail.com \
--cc=jeho@cs.utexas.edu \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pgazz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).