From: Ye Xiang <xiang.ye@intel.com>
To: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Ye Xiang <xiang.ye@intel.com>
Subject: [PATCH 2/4] iio: hid-sensor-trigger: Decrement runtime pm enable count on driver removal
Date: Thu, 19 Nov 2020 11:03:24 +0800 [thread overview]
Message-ID: <20201119030326.6447-3-xiang.ye@intel.com> (raw)
In-Reply-To: <20201119030326.6447-1-xiang.ye@intel.com>
To avoid pm_runtime_disable called repeatedly by hid sensor drivers,
decrease runtime pm enable count after call it.
Signed-off-by: Ye Xiang <xiang.ye@intel.com>
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index ff375790b7e8..30340abcbc8d 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -227,8 +227,10 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
void hid_sensor_remove_trigger(struct iio_dev *indio_dev,
struct hid_sensor_common *attrb)
{
- if (atomic_read(&attrb->runtime_pm_enable))
+ if (atomic_read(&attrb->runtime_pm_enable)) {
pm_runtime_disable(&attrb->pdev->dev);
+ atomic_dec(&attrb->runtime_pm_enable);
+ }
pm_runtime_set_suspended(&attrb->pdev->dev);
pm_runtime_put_noidle(&attrb->pdev->dev);
--
2.17.1
next prev parent reply other threads:[~2020-11-19 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 3:03 [PATCH 0/4] add custom hinge sensor support Ye Xiang
2020-11-19 3:03 ` [PATCH 1/4] HID: hid-sensor-custom: Add custom sensor iio support Ye Xiang
2020-11-19 6:56 ` kernel test robot
2020-11-19 3:03 ` Ye Xiang [this message]
2020-11-19 3:03 ` [PATCH 3/4] iio: hid-sensor-trigger: Use iio->trig instead trig field internal structure Ye Xiang
2020-11-19 3:03 ` [PATCH 4/4] iio: hid-sensors: Add hinge sensor driver Ye Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119030326.6447-3-xiang.ye@intel.com \
--to=xiang.ye@intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).