* [PATCH] Input: soc_button_array - add missing include
@ 2020-11-23 6:15 Dmitry Torokhov
2020-11-23 8:46 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2020-11-23 6:15 UTC (permalink / raw)
To: linux-input; +Cc: Hans de Goede, linux-kernel
This fixes the following build errors:
CC [M] drivers/input/misc/soc_button_array.o
drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration]
irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
^
drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW'
irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
^
2 errors generated.
Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/soc_button_array.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index cae1a3fae83a..d14a65683c5e 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -9,6 +9,7 @@
#include <linux/module.h>
#include <linux/input.h>
#include <linux/init.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/acpi.h>
#include <linux/dmi.h>
--
2.29.2.454.gaff20da3a2-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: soc_button_array - add missing include
2020-11-23 6:15 [PATCH] Input: soc_button_array - add missing include Dmitry Torokhov
@ 2020-11-23 8:46 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2020-11-23 8:46 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: linux-kernel
Hi,
On 11/23/20 7:15 AM, Dmitry Torokhov wrote:
> This fixes the following build errors:
>
> CC [M] drivers/input/misc/soc_button_array.o
> drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration]
> irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
> ^
> drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW'
> irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
> ^
> 2 errors generated.
>
> Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/input/misc/soc_button_array.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index cae1a3fae83a..d14a65683c5e 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -9,6 +9,7 @@
> #include <linux/module.h>
> #include <linux/input.h>
> #include <linux/init.h>
> +#include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-23 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-23 6:15 [PATCH] Input: soc_button_array - add missing include Dmitry Torokhov
2020-11-23 8:46 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).