linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: sanjay.govind9@gmail.com
Cc: aicommander@gmail.com, priv.luk@gmail.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] INPUT: xpad: support Ardwiino Controllers
Date: Mon, 30 Nov 2020 23:17:35 -0800	[thread overview]
Message-ID: <20201201071735.GU2034289@dtor-ws> (raw)
In-Reply-To: <20201201064844.128122-1-sanjay.govind9@gmail.com>

Hi Sanjay,

On Tue, Dec 01, 2020 at 07:48:45PM +1300, sanjay.govind9@gmail.com wrote:
> From: Sanjay Govind <sanjay.govind9@gmail.com>
> 
> This commit adds support for Ardwiino Controllers

Thank you for resending the patch, it now is formatted properly. However
I believe you need to also add information about Ardwiino controllers to
xpad_device table so that they are properly identified by the kernel.

Thanks.

> 
> Signed-off-by: Sanjay Govind <sanjay.govind9@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c77cdb3b62b5..c9d78e2acb38 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -418,6 +418,7 @@ static const struct usb_device_id xpad_table[] = {
>  	XPAD_XBOXONE_VENDOR(0x0f0d),		/* Hori Controllers */
>  	XPAD_XBOX360_VENDOR(0x1038),		/* SteelSeries Controllers */
>  	XPAD_XBOX360_VENDOR(0x11c9),		/* Nacon GC100XF */
> +	XPAD_XBOX360_VENDOR(0x1209),		/* Ardwiino Controllers */
>  	XPAD_XBOX360_VENDOR(0x12ab),		/* X-Box 360 dance pads */
>  	XPAD_XBOX360_VENDOR(0x1430),		/* RedOctane X-Box 360 controllers */
>  	XPAD_XBOX360_VENDOR(0x146b),		/* BigBen Interactive Controllers */
> -- 
> 2.29.2
> 

-- 
Dmitry

  reply	other threads:[~2020-12-01  7:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  6:48 [PATCH] INPUT: xpad: support Ardwiino Controllers sanjay.govind9
2020-12-01  7:17 ` Dmitry Torokhov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-12-01  7:19 sanjay.govind9
2020-12-01  7:45 ` Dmitry Torokhov
     [not found] <CALQgdA3Yh1XjENpFRAaqQ3AXNfp10R-52j77xK=fM2ZPkUJZtA@mail.gmail.com>
2020-12-01  6:39 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201201071735.GU2034289@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aicommander@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=priv.luk@gmail.com \
    --cc=sanjay.govind9@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).