From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-input@vger.kernel.org, "Andre Müller" <andre.muller@web.de>,
"Nick Dyer" <nick.dyer@itdev.co.uk>,
"Jiada Wang" <jiada_wang@mentor.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] Input: atmel_mxt_ts - Fix lost interrupts
Date: Tue, 1 Dec 2020 09:56:58 -0800 [thread overview]
Message-ID: <20201201175658.GX2034289@dtor-ws> (raw)
In-Reply-To: <20201201123026.1416743-1-linus.walleij@linaro.org>
On Tue, Dec 01, 2020 at 01:30:26PM +0100, Linus Walleij wrote:
> After commit 74d905d2d38a devices requiring the workaround
> for edge triggered interrupts stopped working.
>
> The hardware needs the quirk to be used before even
> proceeding to check if the quirk is needed because
> mxt_acquire_irq() is called before mxt_check_retrigen()
> is called and at this point pending IRQs need to be
> checked, and if the workaround is not active, all
> interrupts will be lost from this point.
>
> Solve this by switching the calls around.
>
> Cc: Andre Müller <andre.muller@web.de>
> Cc: Nick Dyer <nick.dyer@itdev.co.uk>
> Cc: Jiada Wang <jiada_wang@mentor.com>
> Cc: stable@vger.kernel.org
> Reported-by: Andre Müller <andre.muller@web.de>
> Tested-by: Andre Müller <andre.muller@web.de>
> Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Fixes: 74d905d2d38a ("Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when necessary")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2020-12-01 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:30 [PATCH v3] Input: atmel_mxt_ts - Fix lost interrupts Linus Walleij
2020-12-01 17:56 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201175658.GX2034289@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andre.muller@web.de \
--cc=jiada_wang@mentor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=nick.dyer@itdev.co.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).