Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property

Rob Herring
2020-12-11T03:18:01Z

On Thu, Dec 10, 2020 at 11:13:50AM +0200, Cristian Ciocaltea wrote:
> Hi Rob,
>
> On Wed, Dec 09, 2020 at 09:37:08PM -0600, Rob Herring wrote:
> > On Sun, Dec 06, 2020 at 03:27:01AM +0200, Cristian Ciocaltea wrote:
> > > Add a new common property 'reset-time-sec' to be used in conjunction
> > > with the devices supporting the key pressed reset feature.
> > >
> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > > ---
> > > Changes in v3:
> > > - This patch was not present in v2
> > >
> > > Documentation/devicetree/bindings/input/input.yaml | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> > > index ab407f266bef..caba93209ae7 100644
> > > --- a/Documentation/devicetree/bindings/input/input.yaml
> > > +++ b/Documentation/devicetree/bindings/input/input.yaml
> > > @@ -34,4 +34,11 @@ properties:
> > > specify this property.
> > > $ref: /schemas/types.yaml#/definitions/uint32
> > >
> > > + reset-time-sec:
> >
> > Humm, I'm pretty sure we already have something for this. Or maybe just
> > power off.
>
> We only have 'power-off-time-sec', so I added 'reset-time-sec' according
> to your review in v2:
> https://lore.kernel.org/lkml/20200908214724.GA959481@bogus/

I'm doing good if I remember reviews from a week ago. From 3 months ago,
no chance without some reminder.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob