Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

Cristian Ciocaltea
2020-12-21T18:06:39Z

On Mon, Dec 21, 2020 at 01:18:01PM +0100, Linus Walleij wrote:
> On Mon, Dec 21, 2020 at 12:59 PM Cristian Ciocaltea
> <cristian.ciocaltea@gmail.com> wrote:
>
> > enum atc260x_ver {
> > ATC260X_A = 0,
> > ATC260X_B,
> > ATC260X_C,
> > ATC260X_D,
> > ATC260X_E,
> > ATC260X_F,
> > ATC260X_G,
> > ATC260X_H,
> > };
>
> This makes it look like the driver is actually so generic that it makes space
> for all revisions back to ATC2603A which is in the Ainol Hero 10 tablet.

For ATC2603A we need an SPI driver, currently only the I2C interface is
supported.

> This is nice because there are millions of these devices (especially in
> China) that people want to get to run the latest Linux.
>
> I even wonder how much different the ATM7029 is from S500, I suspect
> not super much apart from the ARM cores.

Cannot tell, for the moment I can only "play" with the S500..

> Good work overall! I'll be happy to deal with the GPIO
> driver when you get there.

Great, thanks!

> Yours,
> Linus Walleij