From: Maxime Ripard <maxime@cerno.tech>
To: Samuel Holland <samuel@sholland.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support
Date: Wed, 13 Jan 2021 09:28:38 +0100 [thread overview]
Message-ID: <20210113082838.kwwekwwsnpobk7bg@gilmour> (raw)
In-Reply-To: <20210113040542.34247-1-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
On Tue, Jan 12, 2021 at 10:05:39PM -0600, Samuel Holland wrote:
> This series allows the volume keys on the PinePhone to wake up the
> device. As pointed out for v1, wakeup should only be enabled when a
> "wakeup-source" property is present, so v2 requires DT and binding
> changes in addition to the driver change.
>
> Changes since v1:
> - Add requisite DT binding change
> - Only add wakeup capability if "wakeup-source" is present
> - Warn but do not error out if setting the wake IRQ fails
> - Add "wakeup-source" property to PinePhone device tree
>
> Ondrej Jirman (1):
> input: sun4i-lradc-keys - Add wakup support
>
> Samuel Holland (2):
> dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property
> arm64: dts: allwinner: pinephone: Support volume key wakeup
>
> .../input/allwinner,sun4i-a10-lradc-keys.yaml | 2 ++
> .../dts/allwinner/sun50i-a64-pinephone.dtsi | 1 +
> drivers/input/keyboard/sun4i-lradc-keys.c | 22 +++++++++++++++----
> 3 files changed, 21 insertions(+), 4 deletions(-)
Acked-by: Maxime Ripard <mripard@kernel.org>
I've applied patch 3
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-01-13 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 4:05 [PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support Samuel Holland
2021-01-13 4:05 ` [PATCH v2 1/3] dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property Samuel Holland
2021-01-25 19:14 ` Rob Herring
2021-01-13 4:05 ` [PATCH v2 2/3] input: sun4i-lradc-keys - Add wakup support Samuel Holland
2021-01-13 4:05 ` [PATCH v2 3/3] arm64: dts: allwinner: pinephone: Support volume key wakeup Samuel Holland
2021-01-13 8:14 ` [PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support Hans de Goede
2021-01-13 8:28 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113082838.kwwekwwsnpobk7bg@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox