From: Peilin Ye <yepeilin.cs@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Phong Tran <tranmanphong@gmail.com>,
Jason Gerecke <killertofu@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: Fix memory leak in wacom_probe()
Date: Thu, 14 Jan 2021 07:57:42 -0500 [thread overview]
Message-ID: <20210114125742.GA644967@PWN> (raw)
In-Reply-To: <nycvar.YFH.7.76.2101141320210.13752@cbobk.fhfr.pm>
Hi Jiri,
On Thu, Jan 14, 2021 at 01:21:13PM +0100, Jiri Kosina wrote:
> > wacom_probe() is leaking memory. Free `&wacom_wac->pen_fifo` when
> > hid_parse() or wacom_parse_and_register() fails.
>
> Thanks for the patch. It's however already been fixed in
> hid.git#for-5.11/upstream-fixes (37309f47e2f5) branch that will be going
> to Linus shortly.
Ah... I checked linux-input@ before I started working on the bug, but
it seems that Ping sent out a patch just a few hours before I did.
Sorry for the race condition,
Peilin Ye
prev parent reply other threads:[~2021-01-14 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 11:22 [PATCH] HID: wacom: Fix memory leak in wacom_probe() Peilin Ye
2021-01-14 12:21 ` Jiri Kosina
2021-01-14 12:57 ` Peilin Ye [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114125742.GA644967@PWN \
--to=yepeilin.cs@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).