From: Jonathan Cameron <jic23@kernel.org>
To: Ye Xiang <xiang.ye@intel.com>
Cc: jikos@kernel.org, srinivas.pandruvada@linux.intel.com,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: Add relative hysteresis in ABI documentation
Date: Sat, 6 Feb 2021 16:46:34 +0000 [thread overview]
Message-ID: <20210206164634.1e7fa0c4@archlinux> (raw)
In-Reply-To: <20210201074358.18435-4-xiang.ye@intel.com>
On Mon, 1 Feb 2021 15:43:58 +0800
Ye Xiang <xiang.ye@intel.com> wrote:
> Add relative hysteresis in ABI documentation.
>
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index d957f5da5c04..1c51db7eb8ef 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1823,3 +1823,11 @@ Description:
> hinge, keyboard, screen. It means the three channels
> each correspond respectively to hinge angle, keyboard angle,
> and screen angle.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_Y_hysteresis_relative
I'm rather undecided on whether a generic catch all for sensor types here makes
sense. Given we aren't currently applying it to too many devices, I think
I'd prefer we documented this for the particular entries we are adding as
that is the approach that we've taken for the majority of the rest of the
main ABI doc. Note that tidying this doc up has been something I've wanted
to look at doing for a while, so it's possible I'll revisit this decision
at that time.
Otherwise, this looks good.
Thanks,
Jonathan
> +KernelVersion: 5.12
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Specify the percent relative to the current sensor channel
> + Y absolute value that a data field should change before an event
> + is generated. Units are a percentage of the prior reading.
prev parent reply other threads:[~2021-02-06 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 7:43 [PATCH 0/3] Add relative hysteresis support for hid sensors Ye Xiang
2021-02-01 7:43 ` [PATCH 1/3] iio: Add relative sensitivity support Ye Xiang
2021-02-06 16:51 ` Jonathan Cameron
2021-02-01 7:43 ` [PATCH 2/3] iio: hid-sensor-als: Add relative hysteresis support Ye Xiang
2021-02-06 16:52 ` Jonathan Cameron
2021-02-01 7:43 ` [PATCH 3/3] iio: Add relative hysteresis in ABI documentation Ye Xiang
2021-02-06 16:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210206164634.1e7fa0c4@archlinux \
--to=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).