linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Colton Booth <colton@boothsoftware.ca>
To: dmitry.torokhov@gmail.com
Cc: colton@boothlinux.ca, Colton Booth <colton@boothsoftware.ca>,
	Lyude Paul <lyude@redhat.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Lee Jones <lee.jones@linaro.org>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Dennis Kadioglu <denk@eclipso.email>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Yussuf Khalil <dev@pp3345.net>, Ilya Katsnelson <me@0upti.me>,
	Gaurav Agrawal <agrawalgaurav@gnome.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit.
Date: Sat,  6 Feb 2021 22:50:21 -0500	[thread overview]
Message-ID: <20210207035024.69095-1-colton@boothsoftware.ca> (raw)

I can't test myself since I don't have the correct hardware, BUT this change seems to work for him. I'm thinking he has an early version of the X1E which may use slightly different trackpad revision.

Signed-off-by: Colton Booth <colton@boothsoftware.ca>
---
 drivers/input/mouse/synaptics.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ffad142801b3..2d3f03921dbc 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -179,9 +179,7 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0093", /* T480 */
 	"LEN0096", /* X280 */
 	"LEN0097", /* X280 -> ALPS trackpoint */
-	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
 	"LEN009b", /* T580 */
-	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
 	"LEN200f", /* T450s */
 	"LEN2044", /* L470  */
 	"LEN2054", /* E480 */
-- 
2.24.3 (Apple Git-128)


             reply	other threads:[~2021-02-07  4:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07  3:50 Colton Booth [this message]
2021-02-07 10:18 ` [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit Hans de Goede
2021-02-07 10:32   ` Hans de Goede
2021-02-07 15:41 ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210207035024.69095-1-colton@boothsoftware.ca \
    --to=colton@boothsoftware.ca \
    --cc=Jason@zx2c4.com \
    --cc=agrawalgaurav@gnome.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=colton@boothlinux.ca \
    --cc=denk@eclipso.email \
    --cc=dev@pp3345.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=me@0upti.me \
    --cc=vincent.huang@tw.synaptics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).