From: Jeff LaBundy <jeff@labundy.com>
To: Rob Herring <robh@kernel.org>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: input: touchscreen: Move helper bindings to core
Date: Tue, 9 Feb 2021 21:12:46 -0600 [thread overview]
Message-ID: <20210210031246.GB10151@labundy.com> (raw)
In-Reply-To: <20210209162740.GA3874323@robh.at.kernel.org>
Hi Rob,
Thank you for taking a look at the series.
On Tue, Feb 09, 2021 at 10:27:40AM -0600, Rob Herring wrote:
> On Sat, Jan 23, 2021 at 09:42:54PM -0600, Jeff LaBundy wrote:
> > With the helper functions moving to /drivers/input/ following the
> > discussion in [1], touchscreen.yaml and touchscreen.txt are moved
> > one level up as well to maintain a consistent directory structure.
> >
> > No changes are made to either file except to update the $id field
> > in touchscreen.yaml to reflect the new path. The handful of .yaml
> > bindings that reference the original relative path are updated as
> > well.
> >
> > Last but not least, the handful of .txt bindings that included an
> > absolute path to touchscreen.txt are updated too.
> >
> > [1] https://patchwork.kernel.org/patch/11924029/
> >
> > Signed-off-by: Jeff LaBundy <jeff@labundy.com>
> > ---
> > Changes in v2:
> > - Added this patch to the series
> >
> > .../devicetree/bindings/input/elan_i2c.txt | 2 +-
> > .../devicetree/bindings/input/touchscreen.txt | 1 +
> > .../devicetree/bindings/input/touchscreen.yaml | 83 ++++++++++++++++++++++
> > .../bindings/input/touchscreen/ads7846.txt | 2 +-
> > .../bindings/input/touchscreen/bu21013.txt | 2 +-
> > .../input/touchscreen/cypress,cy8ctma140.yaml | 2 +-
> > .../bindings/input/touchscreen/edt-ft5x06.yaml | 2 +-
> > .../bindings/input/touchscreen/eeti,exc3000.yaml | 2 +-
> > .../input/touchscreen/elan,elants_i2c.yaml | 2 +-
> > .../bindings/input/touchscreen/goodix.yaml | 2 +-
> > .../bindings/input/touchscreen/iqs5xx.txt | 2 +-
> > .../bindings/input/touchscreen/mms114.txt | 2 +-
> > .../bindings/input/touchscreen/touchscreen.txt | 1 -
> > .../bindings/input/touchscreen/touchscreen.yaml | 83 ----------------------
> > 14 files changed, 94 insertions(+), 94 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/input/touchscreen.txt
> > create mode 100644 Documentation/devicetree/bindings/input/touchscreen.yaml
> > delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> > delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
>
> No, I prefer the current structure. It's easier to find similar types of
> h/w as-is. In fact, if you wanted to move keyboards/keypads to their own
> subdir, I'd welcome that.
No problem, I will drop this patch from the series and update the $ref in
patch [4/5] to reference the original touchscreen.yaml.
>
> Rob
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2021-02-10 3:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 3:42 [PATCH v2 0/5] Add support for Azoteq IQS626A Jeff LaBundy
2021-01-24 3:42 ` [PATCH v2 1/5] input: touchscreen: Move helper functions to core Jeff LaBundy
2021-01-24 3:42 ` [PATCH v2 2/5] input: touchscreen: Broaden use-cases described in comments Jeff LaBundy
2021-01-24 3:42 ` [PATCH v2 3/5] dt-bindings: input: touchscreen: Move helper bindings to core Jeff LaBundy
2021-02-09 16:27 ` Rob Herring
2021-02-10 3:12 ` Jeff LaBundy [this message]
2021-03-23 3:11 ` Dmitry Torokhov
2021-01-24 3:42 ` [PATCH v2 4/5] dt-bindings: input: Add bindings for Azoteq IQS626A Jeff LaBundy
2021-02-09 16:34 ` Rob Herring
2021-01-24 3:42 ` [PATCH v2 5/5] input: Add support " Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210031246.GB10151@labundy.com \
--to=jeff@labundy.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).