Re: [PATCH v6 00/4] HID: new driver for PS5 'DualSense' controller

[Marek Behun <marek.behun@nic.cz>]

On Sun, 14 Feb 2021 16:45:45 -0800
Roderick Colenbrander <roderick@gaikai.com> wrote:

> From: Roderick Colenbrander <roderick.colenbrander@sony.com>
> 
> Hi,
> 
> Recently Sony released a HID driver for the new PlayStation 5 controller
> 'DualSense'. Pavel Machek noticed the driver got staged for "-next" and asked
> me to share the LED patches to linux-leds as well.
> 
> The LED patches I'm sharing are patch 6, 9, 11, 12 from the v6 hid-playstation
> series as originally posted to linux-input. The driver in its full form can be
> found on "hid.git/log/?h=for-5.12/playstation".
> 

Hi,

OK I see you described the purpose of these LEDs here, please ignore
that one question in my reply to patch 1/4.

> Finally, the DualSense has a audio mute LED and a mute button. The mute button is
> expected to mute the internal microphone of the DualSense. The mute behavior
> is handled driver side and the driver then also programs the LED. From user space
> perspective the LED is read-only.

The audio mute LED should not be read-only from userspace. Instead a
LED trigger should be assigned by default, audio-micmute / audio-mute.

With this trigger the LED subsystem will handle setting brightness of
the LED according to whether the audio is muted or not.

This trigger is currently simple, though. It is system wide - it
is impossible to configure it to report only on the state of a
specific microphone. But the trigger driver can be extended if this is needed.

Marek