From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026CEC433E6 for ; Sun, 21 Feb 2021 01:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B691D64EEC for ; Sun, 21 Feb 2021 01:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbhBUBnI (ORCPT ); Sat, 20 Feb 2021 20:43:08 -0500 Received: from lists.nic.cz ([217.31.204.67]:45858 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhBUBnI (ORCPT ); Sat, 20 Feb 2021 20:43:08 -0500 Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id AA0DE1409DC; Sun, 21 Feb 2021 02:42:25 +0100 (CET) Date: Sun, 21 Feb 2021 02:42:25 +0100 From: Marek Behun To: Hans de Goede Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 6/7] HID: lenovo: Map mic-mute button to KEY_F20 instead of KEY_MICMUTE Message-ID: <20210221024225.4310028d@nic.cz> In-Reply-To: <20210220122438.21857-7-hdegoede@redhat.com> References: <20210220122438.21857-1-hdegoede@redhat.com> <20210220122438.21857-7-hdegoede@redhat.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sat, 20 Feb 2021 13:24:37 +0100 Hans de Goede wrote: > Mapping the mic-mute button to KEY_MICMUTE is technically correct but > KEY_MICMUTE translates to a scancode of 256 (248 + 8) under X, > which does not fit in 8 bits, so it does not work. Why does it need to fit 8 bits? Where is the problem? Marek