From: Pavel Machek <pavel@ucw.cz>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Marek Behún" <kabel@kernel.org>,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/3] HID: elan: Remove elan_mute_led_get_brigtness()
Date: Tue, 23 Feb 2021 10:09:23 +0100 [thread overview]
Message-ID: <20210223090923.GH9750@amd> (raw)
In-Reply-To: <20210221113029.103703-4-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
Hi!
> @@ -461,7 +452,6 @@ static int elan_init_mute_led(struct hid_device *hdev)
>
> mute_led->name = "elan:red:mute";
This probably should not have "elan" prefix.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-23 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 11:30 [PATCH v2 0/3] HID: elan: Mute LED handling fixes and improvements Hans de Goede
2021-02-21 11:30 ` [PATCH v2 1/3] HID: elan: Silence mute LED errors being logged when the device is unplugged Hans de Goede
2021-02-21 11:30 ` [PATCH v2 2/3] HID: elan: Set default_trigger for the mute LED Hans de Goede
2021-02-21 11:30 ` [PATCH v2 3/3] HID: elan: Remove elan_mute_led_get_brigtness() Hans de Goede
2021-02-23 9:09 ` Pavel Machek [this message]
2021-02-23 9:08 ` [PATCH v2 0/3] HID: elan: Mute LED handling fixes and improvements Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223090923.GH9750@amd \
--to=pavel@ucw.cz \
--cc=alsa-devel@alsa-project.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=kabel@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).