linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jiri Kosina <jikos@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-input@vger.kernel.org
Subject: [RFC 0/1] Input: elants_i2c - Do not bind to i2c-hid compatible ACPI instantiated devices
Date: Thu, 25 Feb 2021 12:57:04 +0100	[thread overview]
Message-ID: <20210225115705.83031-1-hdegoede@redhat.com> (raw)

Hi All,

Here is a patch which should fix the touchscreen issues some people have
been seeing on some recent Lenovo AMD CPU using models:
https://bugzilla.kernel.org/show_bug.cgi?id=207759

There are 2 reasons why this is a RFC:

1. It is compile-tested only ATM, I'm waiting for feedback from the
reporters of the issue.

2. The fix which I wrote is somewhat simple. It should work, but there
might be older touchscreens which actually need to use the Elan specific
protocol implemented by elants_i2c.ko; while the ACPI-fwnode describing
the touchscreen falsely contains one of the i2c-hid ACPI compatiblity-id
strings. This would of course be a bug in the ACPI tables, but I have
seen this before.

2. might lead to regressions (or it might be a non-issue) so I was hoping
for some input on this from Benjamin as he originally wroter the elants_i2c
code.

Regards,

Hans



Hans de Goede (1):
  Input: elants_i2c - Do not bind to i2c-hid compatible ACPI
    instantiated devices

 drivers/input/touchscreen/elants_i2c.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.30.1


             reply	other threads:[~2021-02-25 11:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 11:57 Hans de Goede [this message]
2021-02-25 11:57 ` [RFC 1/1] Input: elants_i2c - Do not bind to i2c-hid compatible ACPI instantiated devices Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225115705.83031-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).