From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A00C433FB for ; Sat, 20 Mar 2021 11:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DEC3619A7 for ; Sat, 20 Mar 2021 11:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhCTLMe (ORCPT ); Sat, 20 Mar 2021 07:12:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbhCTLMI (ORCPT ); Sat, 20 Mar 2021 07:12:08 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E811AC0610D1 for ; Sat, 20 Mar 2021 03:56:51 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id l13so8772379qtu.9 for ; Sat, 20 Mar 2021 03:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protocubo.io; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iQYzfriQFS4iM4QGzjdYe/EwNKnei3uiMSlE8+pjoTw=; b=RZJmA14Qn4LiKY6BI3f/uMh2na5/N/aCRPh1Pxn74IU5wK+LTAkUoMJs3JRXIujULC uEYz54pHgXGD/0PRED95NZMQ1GKGfWgI6T8xdCn9GjVbs+r0aZ8wzyxobxh9Y/v5+b0U DSNKHWZ3G0CXB8uvCQhEQz7A9Hawt7nmVwXYg0Vmix+1AKLcgUdAncZbNAOc3mY2Q0DO XHky0fR4qSnNI2jxx+cWWRBdl8C+vaoNs4iS9fFjAGW5hpNDOSE/VHOku8Pqh3GXwAlq xE5h4kZKOaDAiNtB7Q52OuYwI3u8kqLf9blWptjuIqRkfNNuu/AOxl0i6BPoTUuCD9So NFOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iQYzfriQFS4iM4QGzjdYe/EwNKnei3uiMSlE8+pjoTw=; b=EV4jKqtOOC7c0sVdN480owQyqEGEXlXziKsH6ypB6XXC8jwc56dnARNG+XmpOi1W1g VuF5w2iOIcy4/2aGdGGWXdsTdGXzZKEkAeDcezt6d6ijjEuLnVfS0GfxJpD6ntb5fuuh KFyw+IBblgbfzhgFXfG2ZvSGi3UGWBadqO/x1nrqxfgm5V2F3/bTmvT3lQtPd/BL6lNj ELPmyH00nmPIGLf+4EUe8K6pH7OrpdQdnnl83MmEwvROxf7If8jXrSIB77MIrQFzG2+K Gi2bMtARcqFcN7gm75Jq9/Lo4z/n7iOsrWP7Dz4+/fsbMGHakL051IiEJ80PIQT528Jr PUDQ== X-Gm-Message-State: AOAM532jQy0TeFtaaNdDBiIEv50dKbXo84pVZTjzAByN1+g2ekmt5Mul mbTt9kSD3SKUHasZTeqh1FtBc5qj+rpxawMB X-Google-Smtp-Source: ABdhPJz1FMB/45PEuvrU181x6rcn5zNT04hOB3ou2ijZjBDr0Pz7vi5oxJeBK04ql8fXnQDDp8PZqg== X-Received: by 2002:aed:2ce3:: with SMTP id g90mr1873788qtd.308.1616221794679; Fri, 19 Mar 2021 23:29:54 -0700 (PDT) Received: from calvin.localdomain ([2804:14d:5c5a:802e:bdc9:ded9:cc08:a4e9]) by smtp.gmail.com with ESMTPSA id p7sm6221092qkc.75.2021.03.19.23.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 23:29:54 -0700 (PDT) Date: Sat, 20 Mar 2021 03:29:49 -0300 From: Jonas Malaco To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Jean Delvare , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hwmon: add driver for NZXT Kraken X42/X52/X62/X72 Message-ID: <20210320062949.h2ggfmzq7lyn3zsi@calvin.localdomain> References: <20210319045544.416138-1-jonas@protocubo.io> <20210319212640.GA23767@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210319212640.GA23767@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Mar 19, 2021 at 02:26:40PM -0700, Guenter Roeck wrote: > On Fri, Mar 19, 2021 at 01:55:44AM -0300, Jonas Malaco wrote: > > These are "all-in-one" CPU liquid coolers that can be monitored and > > controlled through a proprietary USB HID protocol. > > > > While the models have differently sized radiators and come with varying > > numbers of fans, they are all indistinguishable at the software level. > > > > The driver exposes fan/pump speeds and coolant temperature through the > > standard hwmon sysfs interface. > > > > Fan and pump control, while supported by the devices, are not currently > > exposed. The firmware accepts up to 61 trip points per channel > > (fan/pump), but the same set of trip temperatures has to be maintained > > for both; with pwmX_auto_point_Y_temp attributes, users would need to > > maintain this invariant themselves. > > > > Instead, fan and pump control, as well as LED control (which the device > > also supports for 9 addressable RGB LEDs on the CPU water block) are > > left for existing and already mature user-space tools, which can still > > be used alongside the driver, thanks to hidraw. A link to one, which I > > also maintain, is provided in the documentation. > > > > The implementation is based on USB traffic analysis. It has been > > runtime tested on x86_64, both as a built-in driver and as a module. > > > > Signed-off-by: Jonas Malaco > > Applied (after removing the now unnecessary spinlock.h include). Thanks for catching/fixing that. Jonas > > Thanks, > Guenter