From: Jeff LaBundy <jeff@labundy.com>
To: Rob Herring <robh@kernel.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, David Jander <david@protonic.nl>,
kernel@pengutronix.de
Subject: Re: [PATCH v5 1/8] dt-bindings: input: touchscreen: iqs626a: chnage node name to pass validation
Date: Sat, 22 May 2021 22:09:49 -0500 [thread overview]
Message-ID: <20210523030949.GA27945@labundy.com> (raw)
In-Reply-To: <20210521170830.GA14903@robh.at.kernel.org>
Hi Oleksij and Rob,
I disagree with this patch; the device is neither a touchscreen nor
does the example include any touchscreen properties. The end result
is confusing.
On Fri, May 21, 2021 at 12:08:30PM -0500, Rob Herring wrote:
> On Fri, 21 May 2021 06:45:18 +0200, Oleksij Rempel wrote:
> > Change node name from iqs626a -> touchscreen to pass dt_binding_check.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
What is the failure returned by dt_binding_check? Is it because of
the reference to touchscreen.yaml? If so, I'd rather we update the
tool instead of appease it.
This device leverages the touchscreen helpers for axis swapping or
inversion in 'trackpad' mode, which any input device is free to do
starting with 5.13.
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2021-05-23 3:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 4:45 [PATCH v5 0/8] add z1 and z2 channels support for resistive-adc-touch driver Oleksij Rempel
2021-05-21 4:45 ` [PATCH v5 1/8] dt-bindings: input: touchscreen: iqs626a: chnage node name to pass validation Oleksij Rempel
2021-05-21 16:26 ` Jonathan Cameron
2021-05-21 17:08 ` Rob Herring
2021-05-23 3:09 ` Jeff LaBundy [this message]
2021-05-21 4:45 ` [PATCH v5 2/8] dt-bindings: input: touchscreen: edt-ft5x06: " Oleksij Rempel
2021-05-21 17:09 ` Rob Herring
2021-05-21 4:45 ` [PATCH v5 3/8] dt-bindings: input: touchscreen: goodix: " Oleksij Rempel
2021-05-21 17:17 ` Rob Herring
2021-05-21 4:45 ` [PATCH v5 4/8] dt-bindings: touchscreen: validate nodename Oleksij Rempel
2021-05-21 16:27 ` Jonathan Cameron
2021-05-21 17:18 ` Rob Herring
2021-05-25 3:46 ` Dmitry Torokhov
2021-05-21 4:45 ` [PATCH v5 5/8] dt-bindings: touchscreen: Convert resistive-adc-touch binding to json schema Oleksij Rempel
2021-05-21 16:29 ` Jonathan Cameron
2021-05-21 4:45 ` [PATCH v5 6/8] dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property Oleksij Rempel
2021-05-21 4:45 ` [PATCH v5 7/8] dt-bindings: touchscreen: resistive-adc-touch: add support for z1 and z2 channels Oleksij Rempel
2021-05-21 4:45 ` [PATCH v5 8/8] Input: " Oleksij Rempel
2021-05-21 16:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523030949.GA27945@labundy.com \
--to=jeff@labundy.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).