From: Pavel Machek <pavel@ucw.cz>
To: Roderick Colenbrander <thunderbird2k@gmail.com>
Cc: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
marek.behun@nic.cz, linux-input <linux-input@vger.kernel.org>,
linux-leds@vger.kernel.org,
"Daniel J. Ogorchock" <djogorchock@gmail.com>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Jiri Kosina" <jikos@kernel.org>
Subject: Re: Naming of HID LED devices
Date: Tue, 25 May 2021 22:04:42 +0200 [thread overview]
Message-ID: <20210525200442.GA1106@duo.ucw.cz> (raw)
In-Reply-To: <CAEc3jaBdWwfbMdrdKOc9e19Mb5HD3DE4QUNu+5UseQ9WLt0THQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
Hi!
> > I suggest you simply select one input device (call it primary,
> > probably the one that contains the master joystick) and use its input
> > number....
>
> It is of course an option. Though I recall in the previous discussion,
> technically the LED is registered on the HID device and not on the
> input device, so it is not entirely correct. There are also cases I
> believe where LEDs are directly created for the HID device itself.
> Based on a quick search this includes the 'hid-led' driver. Though its
> naming is probably fixed as we may not want to break user space (not
> sure if anyone is relying on it). There might be other plain HID
> device use cases with LEDs.
I'm not that familiar with HID vs. input differences. We already use
inputX naming for keyboard LEDs.
I'd say lets do that.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2021-05-25 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 5:47 Naming of HID LED devices Roderick Colenbrander
2021-05-21 15:57 ` Marek Behún
2021-05-21 16:12 ` Barnabás Pőcze
2021-05-21 16:04 ` Pavel Machek
2021-05-25 5:55 ` Roderick Colenbrander
2021-05-25 20:04 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525200442.GA1106@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pobrn@protonmail.com \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).