From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [input:next 2732/2735] drivers/input/touchscreen/resistive-adc-touch.c:84 grts_cb() error: uninitialized symbol 'z2'.
Date: Thu, 27 May 2021 13:41:57 +0300 [thread overview]
Message-ID: <20210527104157.GK24442@kadam> (raw)
In-Reply-To: <20210527101951.5q5ixq2tnd7esq2w@pengutronix.de>
On Thu, May 27, 2021 at 12:19:51PM +0200, Oleksij Rempel wrote:
> Hi,
>
> On Thu, May 27, 2021 at 12:30:00PM +0300, Dan Carpenter wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> > head: 6cf3b3abbf0b3b778138c0f8936aa7820af62cfc
> > commit: fb082cd59afa7fbd3a610e9835050675040b1b99 [2732/2735] Input: resistive-adc-touch - add support for z1 and z2 channels
> > config: x86_64-randconfig-m001-20210526 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > New smatch warnings:
> > drivers/input/touchscreen/resistive-adc-touch.c:84 grts_cb() error: uninitialized symbol 'z2'.
> > drivers/input/touchscreen/resistive-adc-touch.c:88 grts_cb() error: uninitialized symbol 'x'.
> > drivers/input/touchscreen/resistive-adc-touch.c:101 grts_cb() error: uninitialized symbol 'y'.
> >
> > Old smatch warnings:
> > drivers/input/touchscreen/resistive-adc-touch.c:101 grts_cb() error: uninitialized symbol 'x'.
> > drivers/input/touchscreen/resistive-adc-touch.c:109 grts_cb() error: uninitialized symbol 'y'.
> >
> > vim +/z2 +84 drivers/input/touchscreen/resistive-adc-touch.c
> >
> > aa132ffb6b0a18 Eugen Hristev 2018-05-22 56 static int grts_cb(const void *data, void *private)
> > aa132ffb6b0a18 Eugen Hristev 2018-05-22 57 {
> > aa132ffb6b0a18 Eugen Hristev 2018-05-22 58 const u16 *touch_info = data;
> > aa132ffb6b0a18 Eugen Hristev 2018-05-22 59 struct grts_state *st = private;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 60 unsigned int x, y, press = 0, z1 = 0, z2;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 61 unsigned int Rt, i;
> > aa132ffb6b0a18 Eugen Hristev 2018-05-22 62
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 63 for (i = 0; i < ARRAY_SIZE(st->ch) && st->ch[i] != GRTS_CH_NONE; i++) {
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 64 switch (st->ch[i]) {
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 65 case GRTS_CH_X:
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 66 x = touch_info[i];
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 67 break;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 68 case GRTS_CH_Y:
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 69 y = touch_info[i];
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 70 break;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 71 case GRTS_CH_PRESSURE:
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 72 press = touch_info[i];
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 73 break;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 74 case GRTS_CH_Z1:
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 75 z1 = touch_info[i];
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 76 break;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 77 case GRTS_CH_Z2:
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 78 z2 = touch_info[i];
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 79 break;
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 80 }
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 81 }
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 82
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 83 if (z1) {
> > fb082cd59afa7f Oleksij Rempel 2021-05-25 @84 Rt = z2;
> >
> > It's likely this is a false positive, but we can see why the static
> > checker would complain.
>
> The presence of this values was validated on probe. Do we really need
> extra set them to 0?
You don't need to do anything. ;) These are a one time email. I just
look it over and hit forward.
Currently GCC's uninitialized variable checking is disabled in the
kernel otherwise there would be more presure to silence the checker
warning.
regards,
dan carpenter
next prev parent reply other threads:[~2021-05-27 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 9:30 [input:next 2732/2735] drivers/input/touchscreen/resistive-adc-touch.c:84 grts_cb() error: uninitialized symbol 'z2' Dan Carpenter
2021-05-27 10:19 ` Oleksij Rempel
2021-05-27 10:41 ` Dan Carpenter [this message]
2021-06-01 6:21 ` Dmitry Torokhov
2021-06-01 10:27 ` Oleksij Rempel
2021-06-02 4:16 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527104157.GK24442@kadam \
--to=dan.carpenter@oracle.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-input@vger.kernel.org \
--cc=lkp@intel.com \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).