From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Bastien Nocera <hadess@hadess.net>,
Gregor Riepl <onitake@gmail.com>,
linux-input@vger.kernel.org
Subject: [PATCH 2/3] Input: silead - add a settings module-parameter
Date: Sun, 13 Jun 2021 12:21:57 +0200 [thread overview]
Message-ID: <20210613102158.16886-3-hdegoede@redhat.com> (raw)
In-Reply-To: <20210613102158.16886-1-hdegoede@redhat.com>
Add a settings module-parameter which can be allowed to specify/override
various device-properties.
Unlike most other touchscreen controllers Silead touchscreens don't tell us
the ranges of the reported x and y coordinates and Silead touchscreens also
often need to have their axis inverted and/or swapped to match the display
coordinates.
Being able to specify the necessary properties through a module parameter,
allows users of new device-models to help us with bringing up support for
new devices without them needing to do a local kernel-build just to modify
these settings.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/touchscreen/silead.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
index a6386b715b7b..269a0df16541 100644
--- a/drivers/input/touchscreen/silead.c
+++ b/drivers/input/touchscreen/silead.c
@@ -58,6 +58,10 @@
#define SILEAD_MAX_FINGERS 10
+static char *settings;
+module_param(settings, charp, 0444);
+MODULE_PARM_DESC(settings, "Override touchscreen settings using a ; separated key=value list, e.g. \"touchscreen-size-x=1665;touchscreen-size-y=1140;touchscreen-swapped-x-y\"");
+
enum silead_ts_power {
SILEAD_POWER_ON = 1,
SILEAD_POWER_OFF = 0
@@ -96,13 +100,13 @@ static int silead_ts_request_input_dev(struct silead_ts_data *data)
input_set_abs_params(data->input, ABS_MT_POSITION_X, 0, 4095, 0, 0);
input_set_abs_params(data->input, ABS_MT_POSITION_Y, 0, 4095, 0, 0);
- touchscreen_parse_properties(data->input, true, &data->prop, NULL);
+ touchscreen_parse_properties(data->input, true, &data->prop, settings);
input_mt_init_slots(data->input, data->max_fingers,
INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED |
INPUT_MT_TRACK);
- if (device_property_read_bool(dev, "silead,home-button"))
+ if (touchscreen_property_read_bool(dev, "silead,home-button", settings))
input_set_capability(data->input, EV_KEY, KEY_LEFTMETA);
data->input->name = SILEAD_TS_NAME;
@@ -369,8 +373,8 @@ static int silead_ts_setup(struct i2c_client *client)
* this.
*/
- if (device_property_read_bool(&client->dev,
- "silead,stuck-controller-bug")) {
+ if (touchscreen_property_read_bool(&client->dev, "silead,stuck-controller-bug",
+ settings)) {
pm_runtime_set_active(&client->dev);
pm_runtime_enable(&client->dev);
pm_runtime_allow(&client->dev);
@@ -437,8 +441,8 @@ static void silead_ts_read_props(struct i2c_client *client)
const char *str;
int error;
- error = device_property_read_u32(dev, "silead,max-fingers",
- &data->max_fingers);
+ error = touchscreen_property_read_u32(dev, "silead,max-fingers", settings,
+ &data->max_fingers);
if (error) {
dev_dbg(dev, "Max fingers read error %d\n", error);
data->max_fingers = 5; /* Most devices handle up-to 5 fingers */
--
2.31.1
next prev parent reply other threads:[~2021-06-13 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 10:21 [PATCH 0/3] Input: touchscreen - Allow setting touchscreen properties with module options Hans de Goede
2021-06-13 10:21 ` [PATCH 1/3] Input: touchscreen - Extend touchscreen_parse_properties() to allow overriding settings with a module option Hans de Goede
2021-06-14 8:48 ` Bastien Nocera
2021-06-14 9:16 ` Gregor Riepl
2021-06-14 11:42 ` Hans de Goede
2021-06-13 10:21 ` Hans de Goede [this message]
2021-06-13 10:21 ` [PATCH 3/3] Input: goodix - add a settings module-parameter Hans de Goede
2021-06-14 8:48 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210613102158.16886-3-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=onitake@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).