From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Bastien Nocera <hadess@hadess.net>,
Gregor Riepl <onitake@gmail.com>,
linux-input@vger.kernel.org
Subject: [PATCH 3/3] Input: goodix - add a settings module-parameter
Date: Sun, 13 Jun 2021 12:21:58 +0200 [thread overview]
Message-ID: <20210613102158.16886-4-hdegoede@redhat.com> (raw)
In-Reply-To: <20210613102158.16886-1-hdegoede@redhat.com>
Add a settings module-parameter which can be allowed to specify/override
various device-properties.
Usuually Goodix touchscreens on x86 devices (where there is no devicetree
to specify the properties) just work. But in some cases the touchscreen is
mounted 90 or 180 degrees rotated vs the display, requiring setting the
touchscreen-x/y-inverted or touchscreen-swapped-x-y properties.
Being able to specify the necessary properties through a module parameter,
allows users of new device-models to help us with bringing up support for
new devices without them needing to do a local kernel-build just to modify
these settings.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/touchscreen/goodix.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 2efb82977115..1bc94c5597ca 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -52,6 +52,10 @@
#define ACPI_GPIO_SUPPORT
#endif
+static char *settings;
+module_param(settings, charp, 0444);
+MODULE_PARM_DESC(settings, "Override touchscreen settings using a ; separated key=value list, e.g. \"touchscreen-fuzz-x=5;touchscreen-fuzz-y=5;touchscreen-swapped-x-y\"");
+
struct goodix_chip_id {
const char *id;
const struct goodix_chip_data *data;
@@ -1026,7 +1030,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)
goodix_read_config(ts);
/* Try overriding touchscreen parameters via device properties */
- touchscreen_parse_properties(ts->input_dev, true, &ts->prop, NULL);
+ touchscreen_parse_properties(ts->input_dev, true, &ts->prop, settings);
if (!ts->prop.max_x || !ts->prop.max_y || !ts->max_touch_num) {
dev_err(&ts->client->dev,
--
2.31.1
next prev parent reply other threads:[~2021-06-13 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 10:21 [PATCH 0/3] Input: touchscreen - Allow setting touchscreen properties with module options Hans de Goede
2021-06-13 10:21 ` [PATCH 1/3] Input: touchscreen - Extend touchscreen_parse_properties() to allow overriding settings with a module option Hans de Goede
2021-06-14 8:48 ` Bastien Nocera
2021-06-14 9:16 ` Gregor Riepl
2021-06-14 11:42 ` Hans de Goede
2021-06-13 10:21 ` [PATCH 2/3] Input: silead - add a settings module-parameter Hans de Goede
2021-06-13 10:21 ` Hans de Goede [this message]
2021-06-14 8:48 ` [PATCH 3/3] Input: goodix " Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210613102158.16886-4-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=onitake@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).