From: Maxim Mikityanskiy <maxtram95@gmail.com>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Oliver Neukum <oneukum@suse.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxim Mikityanskiy <maxtram95@gmail.com>
Subject: [PATCH 3/6] HID: plantronics: Expose headset LEDs
Date: Sun, 4 Jul 2021 01:01:59 +0300 [thread overview]
Message-ID: <20210703220202.5637-4-maxtram95@gmail.com> (raw)
In-Reply-To: <20210703220202.5637-1-maxtram95@gmail.com>
hid-plantronics uses a custom input mapping, where unhandled usages get
ignored. Although these headsets have LEDs, they aren't handled in
plantronics_input_mapping, hence not exposed to the userspace. This
commit fixes it by adding a case for HID_UP_LED.
Tested with Plantronics Blackwire 3220 Series (047f:c056).
Signed-off-by: Maxim Mikityanskiy <maxtram95@gmail.com>
---
drivers/hid/hid-plantronics.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hid/hid-plantronics.c b/drivers/hid/hid-plantronics.c
index e81b7cec2d12..ea056235a591 100644
--- a/drivers/hid/hid-plantronics.c
+++ b/drivers/hid/hid-plantronics.c
@@ -61,6 +61,10 @@ static int plantronics_input_mapping(struct hid_device *hdev,
if (field->application == HID_GD_JOYSTICK)
goto defaulted;
+ /* expose LEDs */
+ if ((usage->hid & HID_USAGE_PAGE) == HID_UP_LED)
+ goto defaulted;
+
/* handle volume up/down mapping */
/* non-standard types or multi-HID interfaces - plt_type is PID */
if (!(plt_type & HID_USAGE_PAGE)) {
--
2.32.0
next prev parent reply other threads:[~2021-07-03 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 22:01 [PATCH 0/6] Add support for common USB HID headset features Maxim Mikityanskiy
2021-07-03 22:01 ` [PATCH 1/6] HID: hid-input: Add offhook and ring LEDs for headsets Maxim Mikityanskiy
2021-07-06 8:02 ` Benjamin Tissoires
2021-07-15 18:57 ` Jiri Kosina
2021-07-15 20:39 ` Dmitry Torokhov
2021-07-15 22:49 ` Pavel Machek
2021-07-16 17:23 ` Maxim Mikityanskiy
2021-08-09 18:30 ` Maxim Mikityanskiy
2021-08-31 19:11 ` Jiri Kosina
2021-09-07 6:30 ` Dmitry Torokhov
2021-07-03 22:01 ` [PATCH 2/6] HID: hid-input: Add phone hook and mic mute buttons " Maxim Mikityanskiy
2021-07-03 22:01 ` Maxim Mikityanskiy [this message]
2021-07-03 22:02 ` [PATCH 4/6] HID: plantronics: Expose headset telephony buttons Maxim Mikityanskiy
2021-07-03 22:02 ` [PATCH 5/6] HID: hid-input: Update LEDs in all HID reports Maxim Mikityanskiy
2021-07-03 22:02 ` [PATCH 6/6] HID: jabra: Change mute LED state to avoid missing key press events Maxim Mikityanskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210703220202.5637-4-maxtram95@gmail.com \
--to=maxtram95@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).