From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B560C4320E for ; Mon, 30 Aug 2021 14:14:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 626FF60F44 for ; Mon, 30 Aug 2021 14:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237050AbhH3OPu (ORCPT ); Mon, 30 Aug 2021 10:15:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:59216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233490AbhH3OPt (ORCPT ); Mon, 30 Aug 2021 10:15:49 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C3CF60524; Mon, 30 Aug 2021 14:14:49 +0000 (UTC) Date: Mon, 30 Aug 2021 15:18:01 +0100 From: Jonathan Cameron To: Miquel Raynal Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Lee Jones , bcousson@baylibre.com, Tony Lindgren , Tero Kristo , Michael Turquette , Stephen Boyd , Thomas Petazzoni , "Ryan J . Barnett" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 32/40] iio: adc: ti_am335x_adc: Get rid of useless gotos Message-ID: <20210830151801.7b06e9d1@jic23-huawei> In-Reply-To: <20210825152518.379386-33-miquel.raynal@bootlin.com> References: <20210825152518.379386-1-miquel.raynal@bootlin.com> <20210825152518.379386-33-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 25 Aug 2021 17:25:10 +0200 Miquel Raynal wrote: > Gotos jumping to a return statement are not really useful, drop them. > > Signed-off-by: Miquel Raynal Acked-by: Jonathan Cameron > --- > drivers/iio/adc/ti_am335x_adc.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index dd2200d2f214..00bbf557e86c 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -616,11 +616,11 @@ static int tiadc_probe(struct platform_device *pdev) > IRQF_SHARED, > &tiadc_buffer_setup_ops); > if (err) > - goto err_free_channels; > + return err; > > err = iio_device_register(indio_dev); > if (err) > - goto err_buffer_unregister; > + return err; > > platform_set_drvdata(pdev, indio_dev); > > @@ -632,8 +632,7 @@ static int tiadc_probe(struct platform_device *pdev) > > err_dma: > iio_device_unregister(indio_dev); > -err_buffer_unregister: > -err_free_channels: > + > return err; > } >