From: Pavel Machek <pavel@ucw.cz>
To: Jiri Kosina <jikos@kernel.org>
Cc: "Daniel Ogorchock" <djogorchock@gmail.com>,
"Roderick Colenbrander" <roderick@gaikai.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input <linux-input@vger.kernel.org>,
linux-leds@vger.kernel.org,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Roderick Colenbrander" <roderick.colenbrander@sony.com>,
"Roderick Colenbrander" <thunderbird2k@gmail.com>
Subject: Re: [PATCH 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.
Date: Wed, 1 Sep 2021 07:19:38 +0200 [thread overview]
Message-ID: <20210901051938.GA6870@amd> (raw)
In-Reply-To: <nycvar.YFH.7.76.2108312109340.15313@cbobk.fhfr.pm>
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
Hi!
> > Do you have any recommendations on what would be an appropriate
> > function string for player indicator LEDs? Would some variant such as:
> > "status-x"
> > "player-status-x"
> > "indicator-x"
> > "player-indicator-x"
> > be more suitable? It looks like the string "status" has been used for
> > other existing LED names.
I guess "player-x" would be suitable.
> > I think we are pretty happy to use whatever naming scheme fits the
> > standards of the led subsystem's userspace api for the Nintendo/Sony
> > HID drivers, and any future game controller drivers featuring player
> > LEDs could conform to that going forward.
>
> Pavel, could you please take a look here, so that we can proceed with the
> patchset?
So... leds tree has just been merged:
> git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/
tags/leds-5.15-rc1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a998a62be9cdb509491731ffe81575aa09943a32
It includes Documentation/leds/well-known-leds.txt file. Could a
section describing proposed naming be added there (both device and
function), with explanations what the LEDs do?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-09-01 5:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 6:12 [PATCH 0/3] HID: playstation: add LED support Roderick Colenbrander
2021-06-02 6:12 ` [PATCH 1/3] HID: playstation: expose DualSense lightbar through a multi-color LED Roderick Colenbrander
2021-06-02 6:12 ` [PATCH 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers Roderick Colenbrander
2021-06-24 13:25 ` Jiri Kosina
2021-07-06 4:51 ` Roderick Colenbrander
2021-07-22 16:22 ` Roderick Colenbrander
2021-08-03 22:10 ` Pavel Machek
2021-08-03 23:29 ` Roderick Colenbrander
2021-08-13 6:00 ` Daniel Ogorchock
2021-08-31 19:09 ` Jiri Kosina
2021-09-01 5:19 ` Pavel Machek [this message]
2021-09-01 20:24 ` Roderick Colenbrander
2021-06-02 6:12 ` [PATCH 3/3] HID: playstation: expose DualSense player LEDs through LED class Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901051938.GA6870@amd \
--to=pavel@ucw.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).