Re: [PATCH v2 45/46] ARM: dts: am43xx: Describe the magnetic reader/ADC1 hardware module

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello,

Miquel Raynal <miquel.raynal@bootlin.com> wrote on Thu,  2 Sep 2021
23:51:43 +0200:

> This hardware module is close to the am33xx ADC module but instead of
> featuring a touchscreen it has a magnetic reader capability.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  arch/arm/boot/dts/am437x-l4.dtsi     | 31 ++++++++++++++++++++++++++--
>  arch/arm/boot/dts/am43xx-clocks.dtsi |  7 +++++++
>  2 files changed, 36 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi
> index 370c4e64676f..7a3dcfc7bfc9 100644
> --- a/arch/arm/boot/dts/am437x-l4.dtsi
> +++ b/arch/arm/boot/dts/am437x-l4.dtsi
> @@ -2350,11 +2350,38 @@ hdq: hdq@0 {
>  		};
>  
>  		target-module@4c000 {			/* 0x4834c000, ap 114 72.0 */
> -			compatible = "ti,sysc";
> -			status = "disabled";
> +			compatible = "ti,sysc-omap4", "ti,sysc";
> +			reg = <0x4c000 0x4>,
> +			      <0x4c010 0x4>;
> +			reg-names = "rev", "sysc";
> +			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> +					<SYSC_IDLE_NO>,
> +					<SYSC_IDLE_SMART>;
> +			clocks = <&l3s_clkctrl AM4_L3S_ADC1_CLKCTRL 0>;
> +			clock-names = "fck";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x0 0x4c000 0x2000>;
> +
> +			magadc: magadc@0 {
> +				compatible = "ti,am4372-magadc";
> +				reg = <0x0 0x2000>;
> +				interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&adc_mag_fck>;
> +				clock-names = "fck";
> +				dmas = <&edma 54 0>, <&edma 55 0>;;

Small typo here, should have a single ';'.
As the series is fairly long, we will see if there is a need to resend
it or not.

> +				dma-names = "fifo0", "fifo1";
> +				status = "disabled";
> +
> +				mag {
> +					compatible = "ti,am4372-mag";
> +				};
> +
> +				adc {
> +					#io-channel-cells = <1>;
> +					compatible ="ti,am4372-adc";
> +				};
> +			};
>  		};
>  
>  		target-module@80000 {			/* 0x48380000, ap 123 42.0 */
> diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
> index c726cd8dbdf1..59b1f592a743 100644
> --- a/arch/arm/boot/dts/am43xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
> @@ -444,6 +444,13 @@ wdt1_fck: wdt1_fck@422c {
>  		reg = <0x422c>;
>  	};
>  
> +	adc_mag_fck: adc_mag_fck@424c {
> +		#clock-cells = <0>;
> +		compatible = "ti,mux-clock";
> +		clocks = <&sys_clkin_ck>, <&dpll_per_m2_ck>;
> +		reg = <0x424c>;
> +	};
> +
>  	l3_gclk: l3_gclk {
>  		#clock-cells = <0>;
>  		compatible = "fixed-factor-clock";

Thanks,
Miquèl