From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A77CC433EF for ; Sun, 5 Sep 2021 13:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E35D960F92 for ; Sun, 5 Sep 2021 13:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237912AbhIENQk (ORCPT ); Sun, 5 Sep 2021 09:16:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:37374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbhIENQi (ORCPT ); Sun, 5 Sep 2021 09:16:38 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2183860F45; Sun, 5 Sep 2021 13:15:28 +0000 (UTC) Date: Sun, 5 Sep 2021 14:18:52 +0100 From: Jonathan Cameron To: Grygorii Strashko Cc: Miquel Raynal , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Dmitry Torokhov , Lee Jones , , Tony Lindgren , , , , , Thomas Petazzoni , Vignesh Raghavendra , Lokesh Vutla , Tero Kristo , Ryan Barnett , Jason Reeder Subject: Re: [PATCH v2 33/46] mfd: ti_am335x_tscadc: Move control register configuration Message-ID: <20210905141830.1a0deaa9@jic23-huawei> In-Reply-To: <3bc1f515-0b3c-ad0c-9624-4d4804899007@ti.com> References: <20210902215144.507243-1-miquel.raynal@bootlin.com> <20210902215144.507243-34-miquel.raynal@bootlin.com> <3bc1f515-0b3c-ad0c-9624-4d4804899007@ti.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, 3 Sep 2021 16:24:22 +0300 Grygorii Strashko wrote: > On 03/09/2021 00:51, Miquel Raynal wrote: > > The datasheet states that most of the configuration should be set in the > > control register in the first place, before actually enabling the > > hardware. So far only half of the configuration was made in the first > > step, which does not make really sense and would complicating the code > > when introducing support for the am437x hardware. > > > > Let's move that register write a bit below to enclose more configuration. > > > > Signed-off-by: Miquel Raynal > > --- > > drivers/mfd/ti_am335x_tscadc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > > index 29ada9da8826..a0db3e4ff265 100644 > > --- a/drivers/mfd/ti_am335x_tscadc.c > > +++ b/drivers/mfd/ti_am335x_tscadc.c > > @@ -239,6 +239,8 @@ static int ti_tscadc_probe(struct platform_device *pdev) > > } > > regmap_write(tscadc->regmap, REG_CTRL, tscadc->ctrl); > > > > + regmap_write(tscadc->regmap, REG_CTRL, tscadc->ctrl); > > + > > Strange change - above 2 lines a the same !? Yup, Looks like this one got handled earlier and the rebase went wrong. So drop it. > > > tscadc_idle_config(tscadc); > > > > /* Enable the TSC module enable bit */ > > >