From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B05C433EF for ; Sun, 5 Sep 2021 13:23:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 951D860F8F for ; Sun, 5 Sep 2021 13:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234410AbhIENY0 convert rfc822-to-8bit (ORCPT ); Sun, 5 Sep 2021 09:24:26 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:35037 "EHLO mslow1.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233827AbhIENY0 (ORCPT ); Sun, 5 Sep 2021 09:24:26 -0400 Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 01A86C1EBC; Sun, 5 Sep 2021 13:23:21 +0000 (UTC) Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1C587C0006; Sun, 5 Sep 2021 13:22:56 +0000 (UTC) Date: Sun, 5 Sep 2021 15:22:56 +0200 From: Miquel Raynal To: Jonathan Cameron Cc: Grygorii Strashko , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Dmitry Torokhov , Lee Jones , , Tony Lindgren , , , , , Thomas Petazzoni , Vignesh Raghavendra , Lokesh Vutla , Tero Kristo , Ryan Barnett , Jason Reeder Subject: Re: [PATCH v2 33/46] mfd: ti_am335x_tscadc: Move control register configuration Message-ID: <20210905152256.48259b8d@xps13> In-Reply-To: <20210905141830.1a0deaa9@jic23-huawei> References: <20210902215144.507243-1-miquel.raynal@bootlin.com> <20210902215144.507243-34-miquel.raynal@bootlin.com> <3bc1f515-0b3c-ad0c-9624-4d4804899007@ti.com> <20210905141830.1a0deaa9@jic23-huawei> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Jonathan, jic23@kernel.org wrote on Sun, 5 Sep 2021 14:18:52 +0100: > On Fri, 3 Sep 2021 16:24:22 +0300 > Grygorii Strashko wrote: > > > On 03/09/2021 00:51, Miquel Raynal wrote: > > > The datasheet states that most of the configuration should be set in the > > > control register in the first place, before actually enabling the > > > hardware. So far only half of the configuration was made in the first > > > step, which does not make really sense and would complicating the code > > > when introducing support for the am437x hardware. > > > > > > Let's move that register write a bit below to enclose more configuration. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > drivers/mfd/ti_am335x_tscadc.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > > > index 29ada9da8826..a0db3e4ff265 100644 > > > --- a/drivers/mfd/ti_am335x_tscadc.c > > > +++ b/drivers/mfd/ti_am335x_tscadc.c > > > @@ -239,6 +239,8 @@ static int ti_tscadc_probe(struct platform_device *pdev) > > > } > > > regmap_write(tscadc->regmap, REG_CTRL, tscadc->ctrl); > > > > > > + regmap_write(tscadc->regmap, REG_CTRL, tscadc->ctrl); > > > + > > > > Strange change - above 2 lines a the same !? > > Yup, Looks like this one got handled earlier and the rebase went wrong. > So drop it. Exactly. That's a rebase issue I didn't notice. Thanks, Miquèl