From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: "Jiri Kosina" <jikos@kernel.org>,
"Michal Malý" <madcatxster@devoid-pointer.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 0/2] HID: lg: fix init of devices when FF is off
Date: Tue, 28 Sep 2021 10:39:04 +0200 [thread overview]
Message-ID: <20210928083906.43983-1-benjamin.tissoires@redhat.com> (raw)
Hi,
foreword: this was only compiled tested and would greatly benefit
from some testing with real hardware.
This was discovered in RHEL 8. There, we disable most of the FF bits
and it appears returning -1 when the bits are disabled just make
the device disappear.
Cheers,
Benjamin
Benjamin Tissoires (2):
HID: lg: do not return an error when FF is disabled
HID: lg4ff: do not return a value for deinit
drivers/hid/hid-lg.h | 6 +++---
drivers/hid/hid-lg4ff.c | 5 ++---
drivers/hid/hid-lg4ff.h | 6 +++---
3 files changed, 8 insertions(+), 9 deletions(-)
--
2.26.3
next reply other threads:[~2021-09-28 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:39 Benjamin Tissoires [this message]
2021-09-28 8:39 ` [PATCH 1/2] HID: lg: do not return an error when FF is disabled Benjamin Tissoires
2021-09-28 8:39 ` [PATCH 2/2] HID: lg4ff: do not return a value for deinit Benjamin Tissoires
2021-09-29 7:43 ` Michal Malý
2021-09-29 8:55 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928083906.43983-1-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madcatxster@devoid-pointer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).