From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: adxl34x - fix sparse warning
Date: Wed, 13 Oct 2021 09:41:09 +0200 [thread overview]
Message-ID: <20211013074109.6xmsxttihev77zkg@pengutronix.de> (raw)
In-Reply-To: <YWZIjb91d6aAwgss@google.com>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Tue, Oct 12, 2021 at 07:46:37PM -0700, Dmitry Torokhov wrote:
> This fixes the following warning from sparse:
>
> CC [M] drivers/input/misc/adxl34x.o
> CHECK drivers/input/misc/adxl34x.c
> drivers/input/misc/adxl34x.c:245:29: warning: cast to restricted __le16
> drivers/input/misc/adxl34x.c:248:29: warning: cast to restricted __le16
> drivers/input/misc/adxl34x.c:251:29: warning: cast to restricted __le16
This was introduced (I think) in commit
e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
. Is this worth a Fixes: line, or mentioning in the commit log?
Other than that:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-13 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 2:46 [PATCH] Input: adxl34x - fix sparse warning Dmitry Torokhov
2021-10-13 7:41 ` Uwe Kleine-König [this message]
2021-10-15 15:20 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013074109.6xmsxttihev77zkg@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).