linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Roderick Colenbrander <roderick@gaikai.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Roderick Colenbrander" <roderick.colenbrander@sony.com>,
	"Barnabás Pőcze" <pobrn@protonmail.com>,
	"Daniel J. Ogorchock" <djogorchock@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] hid: playstation: add LEDS_CLASS dependency
Date: Fri, 29 Oct 2021 13:40:24 +0200	[thread overview]
Message-ID: <20211029114044.1058958-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

The new LED support causes a link failure when the LEDS subsystem
is in a loadable module and the playstation HID driver is built-in:

ld.lld: error: undefined symbol: devm_led_classdev_multicolor_register_ext
>>> referenced by hid-playstation.c
>>>               hid/hid-playstation.o:(ps_lightbar_register) in archive drivers/built-in.a

Add a hard Kconfig dependency on LEDS_CLASS, but allow building with
the multicolor support disabled, as this is apparently meant as an
optional interface.

Fixes: 8c0ab553b072 ("HID: playstation: expose DualSense player LEDs through LED class.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/hid/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a2c3d9b7bd01..cd10c398580e 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -899,6 +899,8 @@ config HID_PLANTRONICS
 config HID_PLAYSTATION
 	tristate "PlayStation HID Driver"
 	depends on HID
+	depends on LEDS_CLASS
+	depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
 	select CRC32
 	select POWER_SUPPLY
 	help
-- 
2.29.2


             reply	other threads:[~2021-10-29 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 11:40 Arnd Bergmann [this message]
     [not found] ` <BY5PR13MB3826F4B874D9EE466B9FF18798879@BY5PR13MB3826.namprd13.prod.outlook.com>
2021-11-01 14:37   ` [PATCH] hid: playstation: add LEDS_CLASS dependency Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211029114044.1058958-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=benjamin.tissoires@redhat.com \
    --cc=djogorchock@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pobrn@protonmail.com \
    --cc=roderick.colenbrander@sony.com \
    --cc=roderick@gaikai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).