From: Andreas Kemnade <andreas@kemnade.info>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
mylene.josserand@free-electrons.com, linus.walleij@linaro.org,
rydberg@bitmath.org, dmitry.torokhov@gmail.com,
robh+dt@kernel.org, alistair23@gmail.com
Subject: Re: [PATCH v2 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5
Date: Fri, 5 Nov 2021 15:21:54 +0100 [thread overview]
Message-ID: <20211105152154.20f5cbd1@aktux> (raw)
In-Reply-To: <20211103114830.62711-3-alistair@alistair23.me>
Hi,
I finally found time to test this.
On Wed, 3 Nov 2021 21:48:28 +1000
Alistair Francis <alistair@alistair23.me> wrote:
[...]
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + touchscreen@24 {
> + compatible = "cypress,tt2100";
> + reg = <0x24>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&tp_reset_ds203>;
> + interrupt-parent = <&pio>;
> + interrupts = <1 5 IRQ_TYPE_LEVEL_LOW>;
hmm, in the code is IRQ_TRIGGER_FALLING but here is LEVEL_LOW, hmm what
it is really?
> + reset-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>;
hmm, if the reset gpio at the chip is active low (I guess it is) that
would indicate an inverter between SoC and gpio. So a nonstandard setup
as an example, probably not a good idea.
Regards,
Andreas
next prev parent reply other threads:[~2021-11-05 14:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 11:48 [PATCH v2 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2021-11-03 11:48 ` [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2021-11-05 15:01 ` Andreas Kemnade
2021-11-06 6:47 ` Dmitry Torokhov
2021-12-01 12:27 ` Alistair Francis
2021-12-13 5:45 ` Dmitry Torokhov
2021-12-13 18:49 ` Andreas Kemnade
2021-12-18 22:18 ` Andreas Kemnade
2021-12-21 23:28 ` Alistair Francis
2021-12-23 13:47 ` Andy Shevchenko
2021-11-03 11:48 ` [PATCH v2 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5 Alistair Francis
2021-11-03 23:07 ` Rob Herring
2021-11-05 14:21 ` Andreas Kemnade [this message]
2021-11-10 12:59 ` Alistair Francis
2021-11-10 17:36 ` Andreas Kemnade
2021-11-11 15:16 ` Linus Walleij
2021-11-18 12:51 ` Alistair Francis
2021-11-03 11:48 ` [PATCH v2 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2021-11-03 11:48 ` [PATCH v2 4/4] ARM: dts: imx7d: remarkable2: Enable the cyttsp5 Alistair Francis
2021-11-06 2:25 ` Dmitry Torokhov
2021-11-05 14:52 ` [PATCH v2 0/4] Add support for the Cypress cyttsp5 Andreas Kemnade
2021-11-25 9:44 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105152154.20f5cbd1@aktux \
--to=andreas@kemnade.info \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mylene.josserand@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).