Re: [PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

["Srivatsa S. Bhat" <srivatsa@csail.mit.edu>]

On Wed, Nov 10, 2021 at 05:40:09PM +0000, Nadav Amit wrote:
> 
> 
> > On Nov 10, 2021, at 9:20 AM, Srivatsa S. Bhat <srivatsa@csail.mit.edu> wrote:
> > 
> > On Tue, Nov 09, 2021 at 01:57:31PM -0800, Joe Perches wrote:
> >> On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote:
> >>>> On Nov 8, 2021, at 4:37 PM, Joe Perches <joe@perches.com> wrote:
> >>>> On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
> >>>> 
> >>>> So it's an exploder not an actual maintainer and it likely isn't
> >>>> publically archived with any normal list mechanism.
> >>>> 
> >>>> So IMO "private" isn't appropriate.  Neither is "L:"
> >>>> Perhaps just mark it as what it is as an "exploder".
> >>>> 
> >>>> Or maybe these blocks should be similar to:
> >>>> 
> >>>> M:	Name of Lead Developer <somebody@vmware.com>
> >>>> M:	VMware <foo> maintainers <linux-<foo>-maintainers@vmlinux.com>
> >> 
> >> Maybe adding entries like
> >> 
> >> M:	Named maintainer <whoever@vmware.com>
> >> R:	VMware <foo> reviewers <linux-<foo>-maintainers@vmware.com>
> >> 
> >> would be best/simplest.
> >> 
> > 
> > Sure, that sounds good to me. I also considered adding "(email alias)"
> > like Juergen suggested, but I think the R: entry is clear enough.
> > Please find the updated patch below.
> > 
> > ---
> > 
> > From f66faa238facf504cfc66325912ce7af8cbf79ec Mon Sep 17 00:00:00 2001
> > From: "Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>
> > Date: Mon, 8 Nov 2021 11:46:57 -0800
> > Subject: [PATCH v2 2/2] MAINTAINERS: Mark VMware mailing list entries as email
> > aliases
> > 
> > VMware mailing lists in the MAINTAINERS file are private lists meant
> > for VMware-internal review/notification for patches to the respective
> > subsystems. Anyone can post to these addresses, but there is no public
> > read access like open mailing lists, which makes them more like email
> > aliases instead (to reach out to reviewers).
> > 
> > So update all the VMware mailing list references in the MAINTAINERS
> > file to mark them as such, using "R: email-alias@vmware.com".
> > 
> > Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
> > Cc: Zack Rusin <zackr@vmware.com>
> > Cc: Nadav Amit <namit@vmware.com>
> > Cc: Vivek Thampi <vithampi@vmware.com>
> > Cc: Vishal Bhakta <vbhakta@vmware.com>
> > Cc: Ronak Doshi <doshir@vmware.com>
> > Cc: pv-drivers@vmware.com
> > Cc: linux-graphics-maintainer@vmware.com
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-rdma@vger.kernel.org
> > Cc: linux-scsi@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Cc: linux-input@vger.kernel.org
> > ---
> > MAINTAINERS | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 118cf8170d02..4372d79027e9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
> > F:	drivers/gpu/drm/vboxvideo/
> > 
> > DRM DRIVER FOR VMWARE VIRTUAL GPU
> > -M:	"VMware Graphics" <linux-graphics-maintainer@vmware.com>
> > M:	Zack Rusin <zackr@vmware.com>
> > +R:	VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>
> > L:	dri-devel@lists.freedesktop.org
> > S:	Supported
> > T:	git git://anongit.freedesktop.org/drm/drm-misc
> > @@ -14189,7 +14189,7 @@ F:	include/uapi/linux/ppdev.h
> > PARAVIRT_OPS INTERFACE
> > M:	Juergen Gross <jgross@suse.com>
> > M:	Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
> > -L:	pv-drivers@vmware.com (private)
> > +R:	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>
> 
> This patch that you just sent seems to go on top of the previous patches
> (as it removes "L: pv-drivers@vmware.com (private)”).
> 

Actually, that's a bit misleading, since I had corrected that entry in
the first patch itself, while adding myself as the maintainer. So
there are still only 2 patches in this series right now.

Thanks for pointing this out! I'll move the VMware list modifications
out of the first patch, to avoid confusion.

> Since the patches were still not merged, I would presume you should squash
> the old 2/2 with this new patch and send v3 of these patches.
> 

I'll send out a v3, and also add Zack Rusin as the maintainer for the
vmmouse sub-driver, since it does not have a named maintainer at the
moment (Zack indicated that he will be taking up the maintainership).

Thank you!

Regards,
Srivatsa