From: Benjamin Valentin <benpicco@googlemail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Subject: [PATCH] Input: xpad - remove 'rumble support' from TODO
Date: Sat, 13 Nov 2021 13:20:55 +0100 [thread overview]
Message-ID: <20211113132055.6a85e04a@rechenknecht2k11> (raw)
In-Reply-To: <20211113131734.46fbc9bf@rechenknecht2k11>
Rumble has been implemented on all controller types for a long while now.
Let's remove this ancient comment that just creates confusion.
Signed-off-by: Benjamin Valentin <benpicco@googlemail.com>
---
drivers/input/joystick/xpad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index d99dd9aed137..18caaf436ed4 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -29,7 +29,6 @@
* TODO:
* - fine tune axes (especially trigger axes)
* - fix "analog" buttons (reported as digital now)
- * - get rumble working
* - need USB IDs for other dance pads
*
* History:
--
2.32.0
next prev parent reply other threads:[~2021-11-13 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 12:17 Input: xpad - add more Xbox one controller IDs Benjamin Valentin
2021-11-13 12:20 ` Benjamin Valentin [this message]
2021-11-14 1:34 ` Cameron Gutman
2021-11-14 19:51 ` Benjamin Valentin
2021-11-14 20:37 ` Benjamin Valentin
2021-11-14 21:14 ` Cameron Gutman
2021-11-16 15:52 ` Benjamin Valentin
2021-11-14 21:05 ` Cameron Gutman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113132055.6a85e04a@rechenknecht2k11 \
--to=benpicco@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).