From: Benjamin Valentin <benpicco@googlemail.com>
To: Cameron Gutman <aicommander@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: Input: xpad - add more Xbox one controller IDs
Date: Tue, 16 Nov 2021 16:52:10 +0100 [thread overview]
Message-ID: <20211116165210.3449a22a@rechenknecht2k11> (raw)
In-Reply-To: <74100aa9-d2aa-6bdd-46be-0d4ffb6496c8@gmail.com>
On Sun, 14 Nov 2021 15:14:38 -0600
Cameron Gutman <aicommander@gmail.com> wrote:
> I like this idea. There's a small risk of causing userspace breakages
> for games matching "Generic X-Box pad" by name, but we already run
> that risk each time we update xpad_devices[] anyway.
Since the button mappings already differ between the original Xbox
controller and the Xbox 360 controller, matching that string would have
always been broken.
> Can you also replace "Generic X-Box pad" with NULL in xpad_devices[]?
> I don't think it would ever be used anymore after this change.
Will do!
Best,
Benjamin
next prev parent reply other threads:[~2021-11-16 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 12:17 Input: xpad - add more Xbox one controller IDs Benjamin Valentin
2021-11-13 12:20 ` [PATCH] Input: xpad - remove 'rumble support' from TODO Benjamin Valentin
2021-11-14 1:34 ` Input: xpad - add more Xbox one controller IDs Cameron Gutman
2021-11-14 19:51 ` Benjamin Valentin
2021-11-14 20:37 ` Benjamin Valentin
2021-11-14 21:14 ` Cameron Gutman
2021-11-16 15:52 ` Benjamin Valentin [this message]
2021-11-14 21:05 ` Cameron Gutman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116165210.3449a22a@rechenknecht2k11 \
--to=benpicco@googlemail.com \
--cc=aicommander@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).