* [PATCH] HID: add USB_HID dependancy to hid-chicony
@ 2021-12-03 7:59 Greg Kroah-Hartman
2021-12-03 8:43 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-03 7:59 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: linux-input, Greg Kroah-Hartman, Stephen Rothwell
The chicony HID driver only controls USB devices, yet did not have a
dependancy on USB_HID. This causes build errors on some configurations
like sparc when building due to new changes to the chicony driver.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 828c2995ec34..e9bc8efed5a1 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -207,7 +207,7 @@ config HID_CHERRY
config HID_CHICONY
tristate "Chicony devices"
- depends on HID
+ depends on USB_HID
default !EXPERT
help
Support for Chicony Tactical pad and special keys on Chicony keyboards.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: add USB_HID dependancy to hid-chicony
2021-12-03 7:59 [PATCH] HID: add USB_HID dependancy to hid-chicony Greg Kroah-Hartman
@ 2021-12-03 8:43 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2021-12-03 8:43 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Kosina, open list:HID CORE LAYER, Stephen Rothwell
On Fri, Dec 3, 2021 at 8:59 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> The chicony HID driver only controls USB devices, yet did not have a
> dependancy on USB_HID. This causes build errors on some configurations
> like sparc when building due to new changes to the chicony driver.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied to for-5.16/upstream-fixes in hid.git
thanks
Cheers,
Benjamin
> ---
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 828c2995ec34..e9bc8efed5a1 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -207,7 +207,7 @@ config HID_CHERRY
>
> config HID_CHICONY
> tristate "Chicony devices"
> - depends on HID
> + depends on USB_HID
> default !EXPERT
> help
> Support for Chicony Tactical pad and special keys on Chicony keyboards.
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 7:59 [PATCH] HID: add USB_HID dependancy to hid-chicony Greg Kroah-Hartman
2021-12-03 8:43 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).