* [PATCH] HID: prodikeys: add USB_HID dependency
@ 2021-12-03 18:59 Arnd Bergmann
2021-12-06 7:44 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-12-03 18:59 UTC (permalink / raw)
To: Jiri Kosina
Cc: Arnd Bergmann, Benjamin Tissoires, Daniel J. Ogorchock,
Barnabás Pőcze, Roderick Colenbrander, linux-input,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Like with the other drivers that recently got fixed, this one
fails to link if USB_HID is disabled or unreachable:
ERROR: modpost: "usb_hid_driver" [drivers/hid/hid-prodikeys.ko] undefined!
Fixes: f237d9028f84 ("HID: add USB_HID dependancy on some USB HID drivers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 74ce789f8636..48d18559670f 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -246,7 +246,7 @@ config HID_MACALLY
config HID_PRODIKEYS
tristate "Prodikeys PC-MIDI Keyboard support"
- depends on HID && SND
+ depends on USB_HID && SND
select SND_RAWMIDI
help
Support for Prodikeys PC-MIDI Keyboard device support.
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] HID: prodikeys: add USB_HID dependency
2021-12-03 18:59 [PATCH] HID: prodikeys: add USB_HID dependency Arnd Bergmann
@ 2021-12-06 7:44 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2021-12-06 7:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jiri Kosina, Arnd Bergmann, Daniel J. Ogorchock,
Barnabás Pőcze, Roderick Colenbrander,
open list:HID CORE LAYER, lkml
Hi Arnd,
On Fri, Dec 3, 2021 at 8:07 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Like with the other drivers that recently got fixed, this one
> fails to link if USB_HID is disabled or unreachable:
>
> ERROR: modpost: "usb_hid_driver" [drivers/hid/hid-prodikeys.ko] undefined!
>
> Fixes: f237d9028f84 ("HID: add USB_HID dependancy on some USB HID drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Looks like you already been beaten to it by Greg:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.16/upstream-fixes&id=30cb3c2ad24b66fb7639a6d1f4390c74d6e68f94
But thanks!
Cheers,
Benjamin
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 74ce789f8636..48d18559670f 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -246,7 +246,7 @@ config HID_MACALLY
>
> config HID_PRODIKEYS
> tristate "Prodikeys PC-MIDI Keyboard support"
> - depends on HID && SND
> + depends on USB_HID && SND
> select SND_RAWMIDI
> help
> Support for Prodikeys PC-MIDI Keyboard device support.
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-06 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 18:59 [PATCH] HID: prodikeys: add USB_HID dependency Arnd Bergmann
2021-12-06 7:44 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).