From: "José Expósito" <jose.exposito89@gmail.com>
To: benjamin@sipsolutions.net
Cc: alexhenrie24@gmail.com, bberg@redhat.com,
benjamin.tissoires@redhat.com, jikos@kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: apple: Add 2021 magic keyboard FN key mapping
Date: Mon, 3 Jan 2022 19:04:18 +0100 [thread overview]
Message-ID: <20220103180418.GA17596@elementary> (raw)
In-Reply-To: <20220102175438.175359-1-jose.exposito89@gmail.com>
On Sun, Jan 02, 2022 at 06:54:39PM +0100, José Expósito wrote:
> Works as expected a code looks good to me.
Actually, just a little comment on the code, sorry for the extra email:
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 2c9c5faa74a9..61dfe983828f 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -70,6 +70,28 @@ struct apple_key_translation {
> u8 flags;
> };
>
> +static const struct apple_key_translation apple2021_fn_keys[] = {
Since this driver handles many devices, I think that renaming this
struct to "magic_keyboard_2021_fn_keys" would help to quickly
understand which is the target device.
next prev parent reply other threads:[~2022-01-03 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 12:50 [PATCH] HID: apple: Add 2021 magic keyboard FN key mapping Benjamin Berg
2021-12-02 6:18 ` Alex Henrie
2022-01-02 17:54 ` José Expósito
2022-01-03 18:04 ` José Expósito [this message]
2022-01-04 10:51 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103180418.GA17596@elementary \
--to=jose.exposito89@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=bberg@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=benjamin@sipsolutions.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).