From: Anjelique Melendez <quic_amelende@quicinc.com>
To: <dmitry.torokhov@gmail.com>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <collinsd@codeaurora.org>,
<bjorn.andersson@linaro.org>, <swboyd@chromium.org>,
<skakit@codeaurora.org>,
Anjelique Melendez <quic_amelende@quicinc.com>
Subject: [PATCH 2/3] input: misc: pm8941-pwrkey: simulate missed key press events
Date: Thu, 20 Jan 2022 12:41:35 -0800 [thread overview]
Message-ID: <20220120204132.17875-3-quic_amelende@quicinc.com> (raw)
In-Reply-To: <20220120204132.17875-1-quic_amelende@quicinc.com>
From: David Collins <collinsd@codeaurora.org>
The status of the keys connected to the KPDPWR_N and RESIN_N pins
is identified by reading corresponding bits in the interrupt real
time status register. If the status has changed by the time that
the interrupt is handled then a press event will be missed.
Maintain a last known status variable to find unbalanced release
events and simulate press events for each accordingly.
Change-Id: I180469a7048a40e490f21d0f8b9504136131e75b
Signed-off-by: David Collins <collinsd@codeaurora.org>
Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
---
drivers/input/misc/pm8941-pwrkey.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/input/misc/pm8941-pwrkey.c b/drivers/input/misc/pm8941-pwrkey.c
index b912ce00ce1c..0ce00736e695 100644
--- a/drivers/input/misc/pm8941-pwrkey.c
+++ b/drivers/input/misc/pm8941-pwrkey.c
@@ -77,6 +77,7 @@ struct pm8941_pwrkey {
u32 code;
u32 sw_debounce_time_us;
ktime_t last_release_time;
+ bool last_status;
const struct pm8941_data *data;
};
@@ -166,6 +167,16 @@ static irqreturn_t pm8941_pwrkey_irq(int irq, void *_data)
if (pwrkey->sw_debounce_time_us && !sts)
pwrkey->last_release_time = ktime_get();
+ /*
+ * Simulate a press event in case a release event occurred without a
+ * corresponding press event.
+ */
+ if (!pwrkey->last_status && !sts) {
+ input_report_key(pwrkey->input, pwrkey->code, 1);
+ input_sync(pwrkey->input);
+ }
+ pwrkey->last_status = sts;
+
input_report_key(pwrkey->input, pwrkey->code, sts);
input_sync(pwrkey->input);
--
2.34.1
next prev parent reply other threads:[~2022-01-20 20:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 20:41 [PATCH 0/3] Add support for pm8941-pwrkey.c Anjelique Melendez
2022-01-20 20:41 ` [PATCH 1/3] input: misc: pm8941-pwrkey: add software key press debouncing support Anjelique Melendez
2022-01-21 4:08 ` Stephen Boyd
2022-01-22 0:04 ` Anjelique Melendez
2022-01-24 19:33 ` Stephen Boyd
2022-01-25 19:24 ` Anjelique Melendez
2022-01-20 20:41 ` Anjelique Melendez [this message]
2022-01-20 20:41 ` [PATCH 3/3] input: misc: pm8941-pwrkey: avoid potential null pointer dereference Anjelique Melendez
2022-01-20 22:18 ` Trilok Soni
2022-01-21 0:15 ` Anjelique Melendez
2022-01-20 23:01 ` Bjorn Andersson
2022-01-21 0:25 ` Anjelique Melendez
2022-01-21 4:18 ` Stephen Boyd
2022-01-24 22:26 ` Bjorn Andersson
2022-01-25 1:55 ` Stephen Boyd
2022-01-25 18:37 ` Bjorn Andersson
2022-01-27 19:51 ` Anjelique Melendez
2022-01-21 3:51 ` [PATCH 0/3] Add support for pm8941-pwrkey.c Stephen Boyd
2022-01-22 0:04 ` Anjelique Melendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120204132.17875-3-quic_amelende@quicinc.com \
--to=quic_amelende@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skakit@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).