From: Stephen Boyd <swboyd@chromium.org>
To: benjamin.tissoires@redhat.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
"Sean O'Brien" <seobrien@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
Subject: [PATCH 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic
Date: Fri, 4 Feb 2022 12:20:16 -0800 [thread overview]
Message-ID: <20220204202021.895426-1-swboyd@chromium.org> (raw)
This is a follow-on to this thread[1] where we discussed the need to
support the vivaldi keyboard function row keys in the google hammer
driver. I've extracted the common code into a new vivaldi-keymap.c file
that can be used by the various keyboard drivers used on ChromeOS
devices to expose the function_row_physmap sysfs attribute. That's a
good place to keep the HID parsing logic for the vivaldi and hammer
keyboards too, so one function goes there for that as well. Finally, we
add support for the function row physmap attribute to the hammer driver.
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Sean O'Brien" <seobrien@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
Stephen Boyd (4):
Input: atkbd: Convert function_row_physmap to u16 array
Input: Extract ChromeOS vivaldi physmap show function
HID: Extract vivaldi hid feature mapping for use in hid-hammer
HID: google: Add support for vivaldi to hid-hammer
Zhengqiao Xia (1):
HID: google: modify HID device groups of eel
drivers/hid/Kconfig | 2 +
drivers/hid/hid-google-hammer.c | 97 +++++++++++++++-----
drivers/hid/hid-vivaldi.c | 88 +-----------------
drivers/input/Kconfig | 7 ++
drivers/input/Makefile | 1 +
drivers/input/keyboard/Kconfig | 2 +
drivers/input/keyboard/atkbd.c | 27 +++---
drivers/input/keyboard/cros_ec_keyb.c | 30 +++----
drivers/input/vivaldi-keymap.c | 125 ++++++++++++++++++++++++++
include/linux/input/vivaldi-keymap.h | 37 ++++++++
10 files changed, 274 insertions(+), 142 deletions(-)
create mode 100644 drivers/input/vivaldi-keymap.c
create mode 100644 include/linux/input/vivaldi-keymap.h
[1] https://lore.kernel.org/r/nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm
base-commit: 26291c54e111ff6ba87a164d85d4a4e134b7315c
--
https://chromeos.dev
next reply other threads:[~2022-02-04 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 20:20 Stephen Boyd [this message]
2022-02-04 20:20 ` [PATCH 1/5] Input: atkbd: Convert function_row_physmap to u16 array Stephen Boyd
2022-02-04 20:20 ` [PATCH 2/5] Input: Extract ChromeOS vivaldi physmap show function Stephen Boyd
2022-02-04 20:20 ` [PATCH 3/5] HID: Extract vivaldi hid feature mapping for use in hid-hammer Stephen Boyd
2022-02-05 0:15 ` kernel test robot
2022-02-05 2:19 ` Stephen Boyd
2022-02-05 3:19 ` kernel test robot
2022-02-04 20:20 ` [PATCH 4/5] HID: google: Add support for vivaldi to hid-hammer Stephen Boyd
2022-02-04 20:20 ` [PATCH 5/5] HID: google: modify HID device groups of eel Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204202021.895426-1-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seobrien@chromium.org \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).