From: Stephen Boyd <swboyd@chromium.org>
To: benjamin.tissoires@redhat.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>
Cc: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
"Sean O'Brien" <seobrien@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Subject: [PATCH v2 5/5] HID: google: modify HID device groups of eel
Date: Wed, 9 Feb 2022 14:55:56 -0800 [thread overview]
Message-ID: <20220209225556.3992827-6-swboyd@chromium.org> (raw)
In-Reply-To: <20220209225556.3992827-1-swboyd@chromium.org>
From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode
Switch of eel hammer will not be detected by system because the
hid-vivaldi driver probes the device. When it is set to
HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch
successfully and also support the vivaldi keyboard layout.
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Sean O'Brien" <seobrien@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
[swboyd@chromium.org: Expand on commit text]
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/hid/hid-google-hammer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index e3dd26ddbd43..8ed75bb0878f 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -636,7 +636,7 @@ static void hammer_remove(struct hid_device *hdev)
static const struct hid_device_id hammer_devices[] = {
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
- { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+ { HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },
--
https://chromeos.dev
next prev parent reply other threads:[~2022-02-09 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 22:55 [PATCH v2 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Stephen Boyd
2022-02-09 22:55 ` [PATCH v2 1/5] Input: atkbd: Convert function_row_physmap to u16 array Stephen Boyd
2022-02-09 22:55 ` [PATCH v2 2/5] Input: Extract ChromeOS vivaldi physmap show function Stephen Boyd
2022-02-09 22:55 ` [PATCH v2 3/5] HID: Extract vivaldi hid feature mapping for use in hid-hammer Stephen Boyd
2022-02-09 22:55 ` [PATCH v2 4/5] HID: google: Add support for vivaldi to hid-hammer Stephen Boyd
2022-02-09 22:55 ` Stephen Boyd [this message]
2022-02-10 22:40 ` [PATCH v2 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209225556.3992827-6-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seobrien@chromium.org \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).