From: Jeff LaBundy <jeff@labundy.com>
To: Markuss Broks <markuss.broks@gmail.com>
Cc: linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: add Imagis touchscreen driver
Date: Thu, 10 Feb 2022 18:50:41 -0600 [thread overview]
Message-ID: <20220211005041.GA51878@nixie71> (raw)
In-Reply-To: <20220211000103.GA51220@nixie71>
Hi Markuss,
One tiny correction to my previous feedback.
On Thu, Feb 10, 2022 at 06:01:03PM -0600, Jeff LaBundy wrote:
> Hi Markuss,
>
> Neat little driver! Some humble feedback below.
>
[...]
> > + error = input_register_device(input_dev);
> > + if (error) {
> > + dev_err(&ts->client->dev,
> > + "Failed to register input device: %d", error);
> > + return error;
> > + }
>
> I suggest using the device-managed version here, as you have no remove callback.
>
Please ignore this bit :)
[...]
Kind regards,
Jeff LaBundy
prev parent reply other threads:[~2022-02-11 0:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 16:37 [PATCH v2 0/2] Add support for Imagis touchscreens Markuss Broks
2022-02-10 16:37 ` [PATCH v2 1/2] dt-bindings: input/touchscreen: bindings for Imagis Markuss Broks
2022-02-10 22:25 ` Rob Herring
2022-02-15 15:15 ` [PATCH v3 0/2] Add support for Imagis touchscreens Markuss Broks
2022-02-15 15:15 ` [PATCH v3 1/2] dt-bindings: input/touchscreen: bindings for Imagis Markuss Broks
2022-02-15 15:54 ` Krzysztof Kozlowski
2022-02-15 15:15 ` [PATCH v3 2/2] Input: add Imagis touchscreen driver Markuss Broks
2022-02-15 16:05 ` Krzysztof Kozlowski
2022-02-10 16:37 ` [PATCH v2 " Markuss Broks
2022-02-11 0:01 ` Jeff LaBundy
2022-02-11 0:50 ` Jeff LaBundy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211005041.GA51878@nixie71 \
--to=jeff@labundy.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=sfr@canb.auug.org.au \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).