From: Stephen Boyd <swboyd@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com,
Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org
Subject: [PATCH v4 0/4] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic
Date: Wed, 16 Feb 2022 11:58:57 -0800 [thread overview]
Message-ID: <20220216195901.1326924-1-swboyd@chromium.org> (raw)
This is a follow-on to this thread[1] where we discussed the need to
support the vivaldi keyboard function row keys in the google hammer
driver. I've extracted the common code into a new vivaldi-fmap.c file
that can be used by the various keyboard drivers used on ChromeOS
devices to expose the function_row_physmap sysfs attribute. Then we make
another file to keep the HID parsing logic common for the vivaldi and
hammer keyboards. Finally, we add support for the function row physmap
attribute to the hammer driver.
Changes from v3 (https://lore.kernel.org/r/20220211012510.1198155-1-swboyd@chromium.org):
* Changed vivaldi-keymap to vivaldi-fmap
Changes from v2 (https://lore.kernel.org/r/20220209225556.3992827-1-swboyd@chromium.org):
* Drop first patch to change to u16
* Change array type to u32 in vivaldi_data
Changes from v1 (https://lore.kernel.org/r/20220204202021.895426-1-swboyd@chromium.org):
* Yet another new file for HID part to fix compilation problems
Stephen Boyd (3):
Input: Extract ChromeOS vivaldi physmap show function
HID: Extract vivaldi hid feature mapping for use in hid-hammer
HID: google: Add support for vivaldi to hid-hammer
Zhengqiao Xia (1):
HID: google: modify HID device groups of eel
drivers/hid/Kconfig | 11 +++
drivers/hid/Makefile | 1 +
drivers/hid/hid-google-hammer.c | 97 +++++++++++++++++++++------
drivers/hid/hid-vivaldi-common.c | 97 +++++++++++++++++++++++++++
drivers/hid/hid-vivaldi.c | 88 ++----------------------
drivers/input/Kconfig | 7 ++
drivers/input/Makefile | 1 +
drivers/input/keyboard/Kconfig | 2 +
drivers/input/keyboard/atkbd.c | 22 ++----
drivers/input/keyboard/cros_ec_keyb.c | 32 +++------
drivers/input/vivaldi-fmap.c | 39 +++++++++++
include/linux/input/vivaldi-fmap.h | 37 ++++++++++
12 files changed, 292 insertions(+), 142 deletions(-)
create mode 100644 drivers/hid/hid-vivaldi-common.c
create mode 100644 drivers/input/vivaldi-fmap.c
create mode 100644 include/linux/input/vivaldi-fmap.h
[1] https://lore.kernel.org/r/nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm
base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566
--
https://chromeos.dev
next reply other threads:[~2022-02-16 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 19:58 Stephen Boyd [this message]
2022-02-16 19:58 ` [PATCH v4 1/4] Input: Extract ChromeOS vivaldi physmap show function Stephen Boyd
2022-02-16 22:23 ` Stephen Boyd
2022-02-28 7:59 ` Dmitry Torokhov
2022-02-16 19:58 ` [PATCH v4 2/4] HID: Extract vivaldi hid feature mapping for use in hid-hammer Stephen Boyd
2022-02-28 8:01 ` Dmitry Torokhov
2022-02-16 19:59 ` [PATCH v4 3/4] HID: google: Add support for vivaldi to hid-hammer Stephen Boyd
2022-02-16 19:59 ` [PATCH v4 4/4] HID: google: modify HID device groups of eel Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216195901.1326924-1-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).