From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B24C4167D for ; Wed, 23 Feb 2022 02:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236921AbiBWCaA (ORCPT ); Tue, 22 Feb 2022 21:30:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233141AbiBWC3l (ORCPT ); Tue, 22 Feb 2022 21:29:41 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C2045792; Tue, 22 Feb 2022 18:28:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4194EB81E01; Wed, 23 Feb 2022 02:28:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE9E8C340EB; Wed, 23 Feb 2022 02:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645583334; bh=Fg2Ald0rbXQJcZNG2Get00sjolUaC9+W+3RpR/4/h4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKPJ+/QaCuaZcXPsnRNQ57/9L8lvhWkD2OrBTlhRaaXg/Jgi7Pjb+I1QTV4x8BxH6 9muhJz5zoyR1Fo816XBcyfR5ZyvUU2aGxlsGNS6KxNNJ1HiUuAoPMYRdPA3gOthW4G MVWnfkawoJklgmxAHTXoiTg8we/1D7RrcK+b4+ye6+yDs5iUG6ZS7KO0IMyQbUUNZd rDA2dEpgrSwr6aL6QXNqnXK3Gd3VHzHPVmtRxReMc1lafMfQR+zUHDnMbNAZFOnUOo NlBP5CCB5CjRBzUHC7/ePJuE39VMpoTQdQqU9wPS7p+LHykX+vZBzpyIrROLIBSYTq IZpw4nGp05TOA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Basavaraj Natikar , Jiri Kosina , Sasha Levin , nehal-bakulchandra.shah@amd.com, basavaraj.natikar@amd.com, jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.16 17/30] HID: amd_sfh: Handle amd_sfh work buffer in PM ops Date: Tue, 22 Feb 2022 21:28:06 -0500 Message-Id: <20220223022820.240649-17-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220223022820.240649-1-sashal@kernel.org> References: <20220223022820.240649-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Basavaraj Natikar [ Upstream commit 0cf74235f4403b760a37f77271d2ca3424001ff9 ] Since in the current amd_sfh design the sensor data is periodically obtained in the form of poll data, during the suspend/resume cycle, scheduling a delayed work adds no value. So, cancel the work and restart back during the suspend/resume cycle respectively. Signed-off-by: Basavaraj Natikar Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c index 2503be0253d3e..98cc50995c1ec 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -290,6 +290,8 @@ static int __maybe_unused amd_mp2_pci_resume(struct device *dev) } } + schedule_delayed_work(&cl_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP)); + return 0; } @@ -312,6 +314,8 @@ static int __maybe_unused amd_mp2_pci_suspend(struct device *dev) } } + cancel_delayed_work_sync(&cl_data->work_buffer); + return 0; } -- 2.34.1