From: David Heidelberg <david@ixit.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: David Heidelberg <david@ixit.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Input: synaptics: change initialization error into warning
Date: Fri, 4 Mar 2022 11:40:55 +0100 [thread overview]
Message-ID: <20220304104055.9048-1-david@ixit.cz> (raw)
Since touchpad work on Dell XPS 9360 as expected while using
Synopsys DesignWare driver, let's assume
warning about not loading driver can be lowered from error to warning.
Lower in some cases useless errors like these to warnings:
psmouse serio1: synaptics: Unable to query device: -5
Signed-off-by: David Heidelberg <david@ixit.cz>
---
drivers/input/mouse/synaptics.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ffad142801b3..ffb13055c7dc 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1668,7 +1668,7 @@ static int __synaptics_init(struct psmouse *psmouse, bool absolute_mode)
error = synaptics_query_hardware(psmouse, &info);
if (error) {
- psmouse_err(psmouse, "Unable to query device: %d\n", error);
+ psmouse_warn(psmouse, "Unable to query device: %d\n", error);
return error;
}
@@ -1824,7 +1824,7 @@ int synaptics_init_smbus(struct psmouse *psmouse)
error = synaptics_query_hardware(psmouse, &info);
if (error) {
- psmouse_err(psmouse, "Unable to query device: %d\n", error);
+ psmouse_warn(psmouse, "Unable to query device: %d\n", error);
return error;
}
@@ -1864,7 +1864,7 @@ int synaptics_init(struct psmouse *psmouse)
error = synaptics_query_hardware(psmouse, &info);
if (error) {
- psmouse_err(psmouse, "Unable to query device: %d\n", error);
+ psmouse_warn(psmouse, "Unable to query device: %d\n", error);
return error;
}
--
2.34.1
reply other threads:[~2022-03-04 10:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304104055.9048-1-david@ixit.cz \
--to=david@ixit.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).