From: "José Expósito" <jose.exposito89@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>, Takashi Iwai <tiwai@suse.de>,
Thorsten Leemhuis <regressions@leemhuis.info>,
Peter Hutterer <peter.hutterer@who-t.net>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
"3.8+" <stable@vger.kernel.org>,
regressions@lists.linux.dev, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: multitouch: fix Dell Precision 7550 and 7750 button type
Date: Mon, 21 Mar 2022 19:48:52 +0100 [thread overview]
Message-ID: <20220321184852.GA20347@elementary> (raw)
In-Reply-To: <CAO-hwJL4=OGv34mXq3de4QEKW15tT4gZDOBxhkuXVh5AeSafeQ@mail.gmail.com>
On Mon, Mar 21, 2022 at 07:22:45PM +0100, Benjamin Tissoires wrote:
> Giving a little bit more context here (and quoting Peter).
>
> """
> The problem with [37ef4c19b4] is that it removes functionality -
> before a clickpad was falsely advertised but the button worked, now in
> the affected devices it simply no longer works because the button code
> gets filtered. And user-space can't work around this.
> ...
> So the main question remains: why are we doing this?
>
> And the answer here is: because libinput can't handle clickpads with
> right buttons. But that's not really true either, libinput just
> doesn't want to, and for no other reason than that it's easier to
> handle it this way.
> """
>
> So basically, we tried to fix a choice on libinput assuming that all
> devices are perfect, for the only sake of making it easy for libinput.
> But the solution prevents further tweaks, and we then need to manually
> quirk devices in the kernel which involves a slightly heavier
> difficulty for end users than just dropping a config file or changing
> a setting in their UI.
>
> With that said, this patch is:
> Nacked-by: me
>
> José, could you send a revert of 37ef4c19b4, and add "Cc:
> stable@vger.kernel.org" and all the other tags for the regression
> tracker bot?
Sure, for reference, this patch should be ignored in favor of:
https://lore.kernel.org/linux-input/20220321184404.20025-1-jose.exposito89@gmail.com/T/
Jose
next prev parent reply other threads:[~2022-03-21 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 19:06 [PATCH] HID: multitouch: fix Dell Precision 7550 and 7750 button type José Expósito
2022-03-21 6:29 ` Thorsten Leemhuis
2022-03-21 9:25 ` Benjamin Tissoires
2022-03-21 18:22 ` Benjamin Tissoires
2022-03-21 18:48 ` José Expósito [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-18 14:37 [REGRESSION] Right touchpad button disabled on Dell 7750 Takashi Iwai
2022-03-18 22:01 ` [PATCH] HID: multitouch: fix Dell Precision 7550 and 7750 button type kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321184852.GA20347@elementary \
--to=jose.exposito89@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).