From: Pavel Rojtberg <rojtberg@gmail.com>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
gregkh@linuxfoundation.org
Cc: Pavel Rojtberg <rojtberg@gmail.com>, lawl <github@dumbinter.net>
Subject: [PATCH 3/3] Input: xpad - Poweroff XBOX360W on mode button long press
Date: Sun, 17 Apr 2022 18:15:26 +0200 [thread overview]
Message-ID: <20220417161526.138019-4-rojtberg@gmail.com> (raw)
In-Reply-To: <20220417161526.138019-1-rojtberg@gmail.com>
From: Pavel Rojtberg <rojtberg@gmail.com>
Newer gamepads turn themselves off when the mode button is held down.
For XBOX360W gamepads we must do this this in the driver.
Signed-off-by: lawl <github@dumbinter.net>
Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
---
drivers/input/joystick/xpad.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 7640cbb..a9894a6 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -620,11 +620,13 @@ struct usb_xpad {
int pad_nr; /* the order x360 pads were attached */
const char *name; /* name of the device */
struct work_struct work; /* init/remove device from callback */
+ time64_t mode_btn_down_ts;
};
static int xpad_init_input(struct usb_xpad *xpad);
static void xpad_deinit_input(struct usb_xpad *xpad);
static void xpadone_ack_mode_report(struct usb_xpad *xpad, u8 seq_num);
+static void xpad360w_poweroff_controller(struct usb_xpad *xpad);
/*
* xpad_process_packet
@@ -776,6 +778,23 @@ static void xpad360_process_packet(struct usb_xpad *xpad, struct input_dev *dev,
}
input_sync(dev);
+
+ /* XBOX360W controllers can't be turned off without driver assistance */
+ if (xpad->xtype == XTYPE_XBOX360W) {
+ if (xpad->mode_btn_down_ts > 0
+ && xpad->pad_present
+ && (ktime_get_seconds() - xpad->mode_btn_down_ts) >= 5) {
+ xpad360w_poweroff_controller(xpad);
+ xpad->mode_btn_down_ts = 0;
+ return;
+ }
+
+ /* mode button down/up */
+ if (data[3] & 0x04)
+ xpad->mode_btn_down_ts = ktime_get_seconds();
+ else
+ xpad->mode_btn_down_ts = 0;
+ }
}
static void xpad_presence_work(struct work_struct *work)
--
2.25.1
next prev parent reply other threads:[~2022-04-17 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 16:15 [PATCH 0/3] Input: xpad - sync with github fork Pavel Rojtberg
2022-04-17 16:15 ` [PATCH 1/3] Input: xpad - add supported devices as contributed on github Pavel Rojtberg
2022-04-18 6:16 ` Greg KH
2022-04-17 16:15 ` [PATCH 2/3] Input: xpad - fix wireless 360 controller breaking after suspend Pavel Rojtberg
2022-04-17 16:15 ` Pavel Rojtberg [this message]
2022-04-18 6:18 ` [PATCH 3/3] Input: xpad - Poweroff XBOX360W on mode button long press Greg KH
2022-04-18 6:45 ` Santosh De Massari
2022-04-18 6:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220417161526.138019-4-rojtberg@gmail.com \
--to=rojtberg@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=github@dumbinter.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).